transport: fixed an overflow in ShardPortIterator

Kulezi · Kulezi · commit 8f0bca8b698a · 2022-09-08T12:39:59.000+02:00
diff --git a/transport/routing.go b/transport/routing.go
@@ -30,14 +30,14 @@ func RandomShardPort(si ShardInfo) uint16 {
 // ShardPortIterator returns iterator for consecutive ports that are
 // mapped to a specific shard on scylla node.
 func ShardPortIterator(si ShardInfo) func() uint16 {
-	port := RandomShardPort(si)
+	port := int(RandomShardPort(si))
 
 	return func() uint16 {
-		port += si.NrShards
+		port += int(si.NrShards)
 		if port > maxPort {
-			port = (minPort+si.NrShards-1)/si.NrShards*si.NrShards + si.Shard
+			port = int((minPort+si.NrShards-1)/si.NrShards*si.NrShards + si.Shard)
 		}
-		return port
+		return uint16(port)
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -30,14 +30,14 @@ func RandomShardPort(si ShardInfo) uint16 {`
`30`	`30`	`// ShardPortIterator returns iterator for consecutive ports that are`
`31`	`31`	`// mapped to a specific shard on scylla node.`
`32`	`32`	`func ShardPortIterator(si ShardInfo) func() uint16 {`
`33`		`- port := RandomShardPort(si)`
	`33`	`+ port := int(RandomShardPort(si))`
`34`	`34`
`35`	`35`	`return func() uint16 {`
`36`		`- port += si.NrShards`
	`36`	`+ port += int(si.NrShards)`
`37`	`37`	`if port > maxPort {`
`38`		`- port = (minPort+si.NrShards-1)/si.NrShards*si.NrShards + si.Shard`
	`38`	`+ port = int((minPort+si.NrShards-1)/si.NrShards*si.NrShards + si.Shard)`
`39`	`39`	`}`
`40`		`- return port`
	`40`	`+ return uint16(port)`
`41`	`41`	`}`
`42`	`42`	`}`
`43`	`43`