fix(scylla-manager): address linter complaints

Author: dkropachev

pkg/service/backup/list.go

@@ -22,13 +22,13 @@ func listManifestsInAllLocations(ctx context.Context, client *scyllaclient.Clien
 		manifests []*ManifestInfo
 	)
 
-	for _, hi := range hosts {
-		if _, ok := locations[hi.Location]; ok {
+	for idx := range hosts {
+		if _, ok := locations[hosts[idx].Location]; ok {
 			continue
 		}
-		locations[hi.Location] = struct{}{}
+		locations[hosts[idx].Location] = struct{}{}
 
-		lm, err := listManifests(ctx, client, hi.IP, hi.Location, clusterID)
+		lm, err := listManifests(ctx, client, hosts[idx].IP, hosts[idx].Location, clusterID)
 		if err != nil {
 			return nil, err
 		}

pkg/service/backup/parallel.go

@@ -32,8 +32,8 @@ func makeHostsLimit(hosts []hostInfo, limits []DCLimit) map[string]hostsLimit {
 	}
 
 	m := make(map[string]hostsLimit, len(dcLimit)+1)
-	for _, h := range hosts {
-		dc := h.DC
+	for idx := range hosts {
+		dc := hosts[idx].DC
 		// If DC has no limit put host under an empty DC
 		if _, ok := dcLimit[dc]; !ok {
 			dc = ""
@@ -42,14 +42,14 @@ func makeHostsLimit(hosts []hostInfo, limits []DCLimit) map[string]hostsLimit {
 		v, ok := m[dc]
 		if !ok {
 			v = hostsLimit{}
-			v.hosts = []hostInfo{h}
+			v.hosts = []hostInfo{hosts[idx]}
 			if dc == "" {
 				v.limit = globalLimit
 			} else {
 				v.limit = dcLimit[dc]
 			}
 		} else {
-			v.hosts = append(v.hosts, h)
+			v.hosts = append(v.hosts, hosts[idx])
 		}
 		m[dc] = v
 	}

pkg/service/backup/purger_test.go

@@ -78,7 +78,7 @@ func TestStaleTags(t *testing.T) {
 	retentionMap.Add(task3, 2, 10)
 	retentionMap.Add(task4, 1, 10)
 
-	// test without cleanup
+	// Test without cleanup
 	tags, oldest, err := staleTags(manifests, retentionMap, false)
 	if err != nil {
 		t.Fatal(err)
@@ -105,7 +105,7 @@ func TestStaleTags(t *testing.T) {
 		t.Fatalf("staleTags() = %s, diff:\n%s", tags.List(), diff)
 	}
 
-	// test with cleanup
+	// Test with cleanup
 	tags, oldest, err = staleTags(manifests, retentionMap, true)
 	if err != nil {
 		t.Fatal(err)

pkg/service/backup/validation.go

@@ -176,9 +176,9 @@ func (s *Service) Validate(ctx context.Context, clusterID, taskID, runID uuid.UU
 		p := newPurger(client, h.IP, log.NopLogger)
 
 		hostForNodeID := func() string {
-			for _, h := range hosts {
-				if h.ID == nodeID {
-					return h.IP
+			for idx := range hosts {
+				if hosts[idx].ID == nodeID {
+					return hosts[idx].IP
 				}
 			}
 			if host := p.Host(nodeID); host != "" {

pkg/service/backup/worker_schema.go

@@ -99,12 +99,12 @@ func (w *worker) UploadSchema(ctx context.Context, hosts []hostInfo) (stepError
 
 	// Select single host per location
 	locations := map[string]hostInfo{}
-	for _, hi := range hosts {
-		locations[hi.Location.String()] = hi
+	for idx := range hosts {
+		locations[hosts[idx].Location.String()] = hosts[idx]
 	}
 	hostPerLocation := make([]hostInfo, 0, len(locations))
-	for _, hi := range locations {
-		hostPerLocation = append(hostPerLocation, hi)
+	for key := range locations {
+		hostPerLocation = append(hostPerLocation, locations[key])
 	}
 
 	f := func(h hostInfo) error {