Skip to content

service cluster: Verify that manager and agent versions match #4322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

service cluster: Verify that manager and agent versions match #4322

wants to merge 3 commits into from

Conversation

atpugtihsrah
Copy link

@atpugtihsrah atpugtihsrah commented Mar 30, 2025 •
edited
Loading

Scylla Manager on start up calls the cluster service to check if the agents and the scylla manager have the same versions.

Please make sure that:

  • Code is split to commits that address a single change
  • Commit messages are informative
  • Commit titles have module prefix
  • Commit titles have issue nr. suffix

@atpugtihsrah atpugtihsrah force-pushed the 4305-sm-agent-version-verify-k6ufyt4ltl branch 2 times, most recently from c8d3142 to bb1a604 Compare April 5, 2025 10:02
@atpugtihsrah atpugtihsrah marked this pull request as ready for review April 5, 2025 10:03
@atpugtihsrah
Copy link
Author

@Michal-Leszczynski Could you please review this PR?

@atpugtihsrah atpugtihsrah changed the title DRAFT: Verify that manager and agent versions match service cluster: Verify that manager and agent versions match Apr 5, 2025
@atpugtihsrah
Copy link
Author

atpugtihsrah commented Apr 7, 2025 •
edited
Loading

Sanity Check was failing because there was no comment on the exported method I created. Added a comment.
It looks like workflows have to be approved each time a new commit is made.

@atpugtihsrah
Copy link
Author

@Michal-Leszczynski Could you please review the PR when you have some time?

@karol-kokoszka
Copy link
Collaborator

Hi @atpugtihsrah, in general this PR is ok, but it just covers the situation where user is just starting scylla-manager-server.
Besides, I see you return an error in such a situation, what blocks server from starting.

Potentially, the check could be done at the beginning of the particular task execution.

The discrepancy between versions may occur at any time, as the manager-server is not responsible for installment of the agents on nodes.
So, check on the server startup is not enough.

Scylla Manager gives a possibility to check versions of agent installed on the nodes -> https://manager.docs.scylladb.com/stable/sctool/status.html#id1

@atpugtihsrah
Copy link
Author

Hi @karol-kokoszka , thanks for the feedback. I'll make some changes.

Potentially, the check could be done at the beginning of the particular task execution.

If the versions don't match, then should the task execution be cancelled/stopped/disallowed?

@atpugtihsrah atpugtihsrah force-pushed the 4305-sm-agent-version-verify-k6ufyt4ltl branch from f5ee1a5 to c228cb9 Compare April 22, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karol-kokoszka karol-kokoszka Awaiting requested review from karol-kokoszka karol-kokoszka is a code owner

@Michal-Leszczynski Michal-Leszczynski Awaiting requested review from Michal-Leszczynski Michal-Leszczynski is a code owner

@VAveryanov8 VAveryanov8 Awaiting requested review from VAveryanov8 VAveryanov8 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify that manager and agent versions match
2 participants
@atpugtihsrah @karol-kokoszka