Scheduler: don't skip cron activations #4310
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous behavior for a long run: Cron activation: |-A-------A-------A------ ... Task execution: |-[EEEEEEEE]------[EEE]-- ... Fixed behavior: Cron activation: |-A-------A-------A------ ... Task execution: |-[EEEEEEEE][EEE]-[EEE]-- ... Previous behavior for retries: Cron activation: |-A-------A-------A----- ... Task execution/retry: |-[E]-[R]-[R]-----[EE]-- ... Fixed behavior: Cron activation: |-A-------A-------A----- ... Task execution/retry: |-[E]-[R]-[R][EE]-[EE]-- ... Fixes #4309
Michal-Leszczynski
force-pushed
the
ml/dont-skip-cron-activations
branch
from
223bc61 to
11592ea
Compare
Michal-Leszczynski
requested review from
karol-kokoszka and
VAveryanov8
as code owners
|
@karol-kokoszka @VAveryanov8 This PR is ready for review! |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the issue where cron activations were being skipped during long task executions and retries by preserving the initial activation time. Key changes include adjustments to the scheduling logic in the Scheduler, updates to the rescheduling mechanism to use an initial activation timestamp, and corresponding tests to verify the new behavior.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/scheduler/scheduler_test.go | Added tests to validate scheduling for long runs, retries, and windows |
| pkg/scheduler/scheduler.go | Modified scheduling/rescheduling logic to use initial activation time |
| pkg/scheduler/activation.go | Added new field and helper for initial activation tracking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behavior for a long run:
Fixed behavior:
Previous behavior for retries:
Fixed behavior:
Fixes #4309