Skip to content

revisit dns_resolver::impl::do_sendv() as c-ares now handles EWOULDBLOCK for UDP #2489

Open
@tchaikov

Description

quote from #2472 (comment)

Finally, I should mention this note is no longer valid in your source code:
seastar/src/net/dns.cc
Line 1017 in bddc7b2
// 1.) c-ares does not handle EWOULDBLOCK for

we always pretend that we are able to send the whole payload even when the promise of the write promise is not available immediately. seems this approach simplifies the implementation. but either way, according to Brad, the comment does not apply anymore.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions