How to make 'seastar::connected_socket' and RAII work together?

[kelbon]

Same question about seastar::sharded etc.

I have seastar::connected_socket.
It requires, that its .close must be called AND awaited before destructor. I dont see how it may work with RAII, i run into endless asserions in socket destructor / memory leaks on program end when in destructor i start future with "correct" socket destruction and move socket into it

Also, i dont see any example how to close seastar socket correctly. Is this code correctly closes seastar::connected_socket ?

seastar::future<> close_socket(socket_its_input_and_its_output impl) {
try {
  co_await impl->input.close();
  while (!impl->input.eof()) {
    co_await impl->input.read();
  }
  co_await impl->output.close();
  impl->sock.shutdown_input();
  impl->sock.shutdown_output();
  co_await impl->sock.wait_input_shutdown();
catch(...) {
}
}

[xemul]

Usually the sequence for something that should be closed regardless of what is like

    auto f = co_await open();
    std::exception_ptr ex;
    try {
         /* do whatever is needed with f */
    } catch (...) {
        ex = std::current_exception();
    }
    co_await f.close();
    if (ex) {
        std::rethrow_exception(ex);
    }

for convenience there's with_closeable() helper in seastar.

None of the above is RAII-sh, but ... alas