Skip to content

Add sensors #3

Open
Open
@scondas

Description

  • waterfurnace version: 1.1.0
  • Python version: 3.7
  • Operating System: Windows 10

Description

I was trying to retrieve the Leaving Water Temperature (LWT) and the loop flow rate data that
is available on some Water Furnace units. The current waterfurnace code does not support
these sensors.

What I Did

Looked at the code and did not see the LeavingWaterTemp and WaterFlowRate sensors
being queried.  

Activity

mdallaire

mdallaire commented on Nov 30, 2019

@mdallaire
Contributor

Can you check this thread home-assistant/core#18306 (comment) and run a chrome debug to find out/confirm the value name returned for your system?

scondas

scondas commented on Nov 30, 2019

@scondas
Author

The sensors I am looking for do not appear in the awlclientproxy messages you referenced. I have hacked your code and guessed the sensor names as LeavingWaterTemp and WaterFlowRate, and they are reporting reasonable values against a Series 7 system. I am now working on a patch following the instructions in your repo. I do not, however, have a series 5 to test against to make sure it works correctly against those units.

scondas

scondas commented on Nov 30, 2019

@scondas
Author

mdallaire, I am getting the following error on the flake8 test BEFORE I added my changes:

tests/test_waterfurnace.py:10:1: F401 'waterfurnace.waterfurnace' imported but unused

Is this correct?

scondas

scondas commented on Dec 2, 2019

@scondas
Author

I found a bug I introduced into cli.py. I have deleted that branch. Sorry

scondas

scondas commented on Jun 23, 2020

@scondas
Author

Can you check this thread home-assistant/core#18306 (comment) and run a chrome debug to find out/confirm the value name returned for your system?

mdallaire Are you considering accepting my proposed changes, or should I instead fork the code? Thanks.

mdallaire

mdallaire commented on Jun 23, 2020

@mdallaire
Contributor

I am not the owner of the repo, I just tried to help you figure out the correct websocket values. @sdague is the owner of the repo and would need to merge the change.
However I suspect that you will need to rework it since it looks like you request to merge your whole python venv.

scondas

scondas commented on Jun 23, 2020

@scondas
Author

Thanks!

I am not the owner of the repo, I just tried to help you figure out the correct websocket values. @sdague is the owner of the repo and would need to merge the change.
However I suspect that you will need to rework it since it looks like you request to merge your whole python venv.

Thanks!

linked a pull request that will close this issue on Aug 7, 2020
dougfultz

dougfultz commented on Aug 8, 2022

@dougfultz

@sdague Any chance we can get #7 merged in and get https://pypi.org/project/waterfurnace updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Participants

    @dougfultz@mdallaire@scondas

    Issue actions

      Add sensors · Issue #3 · sdague/waterfurnace