Add FabricSpark dbt-date integration tests and move BaseDbtPackageTests to shared module#228
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
Adds a new FabricSpark integration test that exercises the upstream dbt-date package’s integration_tests project against the fabricspark adapter, validating that Spark-dispatched macros work correctly in FabricSpark.
Changes:
- Introduces
TestDbtDateintegration test suite for FabricSpark, pullingdbt-date(and itsintegration_testssubdirectory) from GitHub at0.17.2. - Configures
dbt_date:time_zonetoAmerica/Los_Angelesand adds dispatch for thedbt_date_integration_testsnamespace. - Runs the full package workflow (
deps,seed,run,test) as part of the integration test.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c6c50ee to
67722f9
Compare
2306c2b to
4b8dea6
Compare
4b8dea6 to
7ff6cdd
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
7ff6cdd to
0b4ab2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestDbtDateintests/fabricspark/packages/test_dbt_date.pyBaseDbtPackageTestsfromtests/fabric/packages/totests/packages/so both Fabric and FabricSpark suites import from a shared, adapter-neutral locationdbt_date_repoanddbt_date_revisionfixtures fromBaseDbtPackageTestsspark__macros (found via FabricSpark'sdependencies=["spark"]dispatch chain)America/Los_Angelestimezone to match dbt-date's Spark integration test fixturesexpression_is_truetests: upstream fixture renderscast('to_date(...)' as date)with nested single quotes causing SparkPARSE_SYNTAX_ERRORTest plan
uv run pytest --de -k "TestDbtDate"against a Fabric Lakehouse — 1 passed (6 models, 0 errors)uv run pytest --dw -k "packages"to verify Fabric package tests still work with the new import path — 7 passed (TestDbtDate Fabric failure is pre-existing, unrelated to import change)spark__macros work via FabricSpark'sdependencies=["spark"]dispatch chainCloses #175
🤖 Generated with Claude Code