Fix snapshot_meta_column_names test assertion for dataclass change#254
Merged
Conversation
dbt-core changed snapshot_meta_column_names from a plain dict to a SnapshotMetaColumnNames dataclass. Update the test assertion to compare against the dataclass instance instead of a dict. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
|
/test-dw -k TestBaseSnapshotInvalidColumnNames |
|
❌ DW integration tests failed Filter: |
There was a problem hiding this comment.
Pull request overview
This PR updates a Fabric adapter snapshot configuration test to match dbt-core’s newer SnapshotMetaColumnNames dataclass representation instead of comparing against a plain dictionary.
Changes:
- Imports
SnapshotMetaColumnNamesfrom dbt-core artifacts. - Updates the snapshot meta column names assertion to compare against a dataclass instance.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
Author
|
/test-dw TestBaseSnapshotInvalidColumnNames |
|
✅ DW integration tests passed Filter: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
snapshot_meta_column_namesfrom a plaindictto aSnapshotMetaColumnNamesdataclass (which includesdbt_is_deleted=None)Test plan
TestBaseSnapshotInvalidColumnNamesvia/test-dw -k TestBaseSnapshotInvalidColumnNames🤖 Generated with Claude Code