sleep vs wait

Author: sderrow

.oxlintrc.json

@@ -32,7 +32,6 @@
     "no-await-in-loop": "off",
     "no-underscore-dangle": "off", // Disabled because it's a common pattern in the codebase
     "no-array-constructor": "error",
-    "prefer-arrow-callback": "warn",
     "typescript/no-explicit-any": "off", // Disabled because it's a common pattern in the codebase
     "typescript/no-require-imports": "off", // Disabled because it's a common pattern in the codebase
     "typescript/no-unsafe-function-type": "error",

.vscode/settings.json

@@ -1,5 +1,5 @@
 {
   "editor.defaultFormatter": "oxc.oxc-vscode",
   "editor.formatOnSave": true,
-  "typescript.tsdk": "node_modules/typescript/lib"
+  "js/ts.tsdk.path": "node_modules/typescript/lib"
 }

test/batcher.test.js

@@ -1,4 +1,4 @@
-import { useFakeClock, wait } from "./helpers/clock.js";
+import { useFakeClock, sleep } from "./helpers/clock.js";
 import { test, describe, expect } from "./helpers/test-api.js";
 const Bottleneck = require("./bottleneck");
 
@@ -85,7 +85,7 @@ describe("Batcher", () => {
 
     const t0 = Date.now();
     const p1 = batcher.add(1);
-    await wait(50);
+    await sleep(50);
     const p2 = batcher.add(2);
     await Promise.all([p1, p2]);
 
@@ -110,7 +110,7 @@ describe("Batcher", () => {
 
     const t1 = Date.now();
     const p4 = batcher.add(4);
-    await wait(50);
+    await sleep(50);
     const p5 = batcher.add(5);
     await Promise.all([p4, p5]);
 

test/cluster-coordination.test.js

@@ -1,3 +1,4 @@
+import { sleep } from "./helpers/clock.js";
 import { test, describe, expect, waitForState, deferred } from "./helpers/test-api.js";
 const Bottleneck = require("./bottleneck");
 const Scripts = require("../src/cluster/Scripts.js");
@@ -517,7 +518,7 @@ describe("Cluster coordination", () => {
       })
       .then(function (doneCount) {
         expect(doneCount).toEqual(1);
-        return h.wait(400);
+        return sleep(400);
       })
       .then(function () {
         return countKeys(limiter);

test/general-traffic.test.js

@@ -1,4 +1,4 @@
-import { useFakeClock, useRealClockForThisTest } from "./helpers/clock.js";
+import { sleep, useFakeClock, useRealClockForThisTest } from "./helpers/clock.js";
 import { test, describe, expect, waitForState, deferred } from "./helpers/test-api.js";
 
 const path = require("path");
@@ -251,7 +251,7 @@ describe("General traffic", () => {
             // (`Date.now() - t0 > 145`) verifies j1 actually ran a
             // meaningful interval, without depending on a fixed timer that
             // can race event-loop jitter.
-            return h.wait(100).then(function () {
+            return sleep(100).then(function () {
               holdJ1.release();
             });
           }),

test/helpers/clock.js

@@ -39,7 +39,7 @@ export function useRealClockForThisTest() {
 }
 
 /** Promise delay via global setTimeout (respects fake timers when installed). */
-export function wait(ms) {
+export function sleep(ms) {
   return new Promise((resolve) => {
     setTimeout(resolve, ms);
   });

test/helpers/test-api.js

@@ -1,5 +1,5 @@
 import { test as baseTest, expect as vitestExpect, vi } from "vitest";
-import { wait, isFakeClock } from "./clock.js";
+import { isFakeClock } from "./clock.js";
 import { createTaskFns } from "./job-tasks.js";
 import makeLimiterHelper from "./limiter.js";
 
@@ -64,7 +64,6 @@ function createJobHarness() {
     flushLimiter: flushLimiter,
     pNoErrVal: pNoErrVal,
     noErrVal: noErrVal,
-    wait: wait,
     callTimes: callTimes,
   };
 }