refactor: import sleep directly; dedup randomIndex

Drop the clock.js re-export — consumers import src/sleep.js directly
(global-setup already did). Extract the byte-identical _randomIndex
bodies in Bottleneck and Job into src/random-index.js. No utils junk
drawer: one concept per module stays the house style.

Author: sderrow

src/Bottleneck.js

@@ -10,6 +10,7 @@ const Events = require("./Events");
 const States = require("./States");
 const Sync = require("./Sync");
 const BottleneckError = require("./BottleneckError");
+const randomIndex = require("./random-index");
 const Group = require("./Group");
 const RedisConnection = require("./cluster/RedisConnection");
 const IORedisConnection = require("./cluster/IORedisConnection");
@@ -179,7 +180,7 @@ class Bottleneck {
   }
 
   _randomIndex() {
-    return Math.random().toString(36).slice(2);
+    return randomIndex();
   }
 
   check(weight = 1) {

src/Job.js

@@ -3,6 +3,7 @@ const DEFAULT_PRIORITY = 5;
 
 const parser = require("./parser");
 const BottleneckError = require("./BottleneckError");
+const randomIndex = require("./random-index");
 
 class Job {
   constructor(task, args, options, jobDefaults, rejectOnDrop, Events, _states) {
@@ -14,7 +15,7 @@ class Job {
     this.options = parser.load(options, jobDefaults);
     this.options.priority = this._sanitizePriority(this.options.priority);
     if (this.options.id === jobDefaults.id) {
-      this.options.id = `${this.options.id}-${this._randomIndex()}`;
+      this.options.id = `${this.options.id}-${randomIndex()}`;
     }
     this.promise = new Promise((_resolve, _reject) => {
       this._resolve = _resolve;
@@ -34,10 +35,6 @@ class Job {
     }
   }
 
-  _randomIndex() {
-    return Math.random().toString(36).slice(2);
-  }
-
   doDrop(params) {
     const { error, message = "This job has been dropped by Bottleneck" } = params || {};
     if (this._states.remove(this.options.id)) {

src/random-index.js

@@ -0,0 +1,4 @@
+/** Compact random id used for job indexes and datastore client ids. */
+const randomIndex = () => Math.random().toString(36).slice(2);
+
+module.exports = randomIndex;

test/batcher.test.js

@@ -1,5 +1,6 @@
 import { describe, expect } from "vitest";
-import { useFakeClock, sleep } from "./helpers/clock.js";
+import sleep from "../src/sleep.js";
+import { useFakeClock } from "./helpers/clock.js";
 import { test } from "./helpers/test-api.js";
 const Bottleneck = require("./bottleneck");
 

test/cluster-coordination.test.js

@@ -1,5 +1,5 @@
 import { describe, expect } from "vitest";
-import { sleep } from "./helpers/clock.js";
+import sleep from "../src/sleep.js";
 import { test, waitForState, deferred } from "./helpers/test-api.js";
 const Bottleneck = require("./bottleneck");
 const Scripts = require("../src/cluster/Scripts.js");

test/general-traffic.test.js

@@ -1,5 +1,6 @@
 import { describe, expect } from "vitest";
-import { sleep, useFakeClock, useRealClockForThisTest } from "./helpers/clock.js";
+import sleep from "../src/sleep.js";
+import { useFakeClock, useRealClockForThisTest } from "./helpers/clock.js";
 import { test, waitForState, deferred } from "./helpers/test-api.js";
 
 const path = require("path");

test/group.test.js

@@ -1,5 +1,6 @@
 import { describe, expect } from "vitest";
-import { useFakeClock, sleep } from "./helpers/clock.js";
+import sleep from "../src/sleep.js";
+import { useFakeClock } from "./helpers/clock.js";
 import { test, waitForState } from "./helpers/test-api.js";
 const Bottleneck = require("./bottleneck");
 

test/helpers/clock.js

@@ -37,6 +37,3 @@ export function useFakeClock() {
 export function useRealClockForThisTest() {
   vi.useRealTimers();
 }
-
-// Shared with src: reads the global setTimeout at call time, so it respects fake timers when installed.
-export { default as sleep } from "../../src/sleep.js";

test/helpers/job-tasks.js

@@ -1,4 +1,4 @@
-import { sleep } from "./clock.js";
+import sleep from "../../src/sleep.js";
 
 /**
  * Manually-released signal for {@link createTaskFns}'s deferredJob/deferredPromise.