Commit cf195a9
authored
[ResponseOps][Alerting v2] Use isFetching instead of isLoading in episode assignee filter (elastic#273019)
## 📄 Summary
> [!important]
> Alerting v2 work under feature flag disabled by default. See 🧪
Verification steps > ⚙️ Environment Setup for more information.
- Switches from `isLoading` to `isFetching` in the `useBulkGetProfiles`
query to avoid showing an infinite loading state when the query is
disabled (when no episode in the table has an assignee and no textual
search is performed)
<details>
<summary>
## 🧪 Verification steps
</summary>
### ⚙️ Environment Setup
Add the following flag to your `kibana.dev.yml` to enable alerting v2:
```yaml
xpack.alerting_v2.enabled: true
```
### ✅ Happy Path
1. Create one or more v2 rules that fire alert episodes
2. Navigate to the Episodes list page
3. Open the filter by assignee
4. Verify that it shows an empty state instead of loading
### ⚡️ Edge Cases
- Open the empty filter, then start typing a name and verify that the
popover shows the user's name
- Assign an episode to a user and verify that the filter by assignee
shows the user's name
</details>
## ⏪ Backport rationale
Pre-GA alerting v2 work, not backporting
## 🔗 References
Fixes elastic/rna-program#571
## ☑️ Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.1 parent 64e3835 commit cf195a9
2 files changed
Lines changed: 33 additions & 13 deletions
File tree
Lines changed: 29 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
42 | 39 | | |
43 | 40 | | |
44 | 41 | | |
| |||
52 | 49 | | |
53 | 50 | | |
54 | 51 | | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
55 | 57 | | |
56 | 58 | | |
57 | 59 | | |
| |||
129 | 131 | | |
130 | 132 | | |
131 | 133 | | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
132 | 150 | | |
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
34 | 36 | | |
35 | 37 | | |
36 | 38 | | |
| |||
91 | 93 | | |
92 | 94 | | |
93 | 95 | | |
94 | | - | |
| 96 | + | |
95 | 97 | | |
96 | 98 | | |
97 | 99 | | |
| |||
0 commit comments