refactor: simplify health response reason field

marc0der · marc0der · commit 1568f27f1df5 · 2025-08-15T23:32:09.000+01:00
diff --git a/src/main/kotlin/io/sdkman/broker/adapter/primary/rest/HealthResponseHandlers.kt b/src/main/kotlin/io/sdkman/broker/adapter/primary/rest/HealthResponseHandlers.kt
@@ -34,8 +34,7 @@ suspend fun ApplicationCall.handleDatabaseHealthStatus(databaseStatus: DatabaseH
     val overallHealthy = databaseStatus.mongodb == HealthStatus.UP && databaseStatus.postgres == HealthStatus.UP
     val statusCode = if (overallHealthy) HttpStatusCode.OK else HttpStatusCode.ServiceUnavailable
 
-    val reason = "Service is ${if (overallHealthy) "healthy" else "not healthy"}"
-    respond(statusCode, DetailedHealthResponse(mongoDbStatus, postgresStatus, reason))
+    respond(statusCode, DetailedHealthResponse(mongoDbStatus, postgresStatus))
 }
 
 suspend fun ApplicationCall.handleHealthError(error: HealthCheckError) {
@@ -114,4 +113,4 @@ private fun createDatabaseErrorResponse(
 }
 
 @Serializable
-data class DetailedHealthResponse(val mongodb: String, val postgres: String, val reason: String)
+data class DetailedHealthResponse(val mongodb: String, val postgres: String, val reason: String? = null)

Original file line number	Diff line number	Diff line change
`@@ -34,8 +34,7 @@ suspend fun ApplicationCall.handleDatabaseHealthStatus(databaseStatus: DatabaseH`
`34`	`34`	`val overallHealthy = databaseStatus.mongodb == HealthStatus.UP && databaseStatus.postgres == HealthStatus.UP`
`35`	`35`	`val statusCode = if (overallHealthy) HttpStatusCode.OK else HttpStatusCode.ServiceUnavailable`
`36`	`36`
`37`		`- val reason = "Service is ${if (overallHealthy) "healthy" else "not healthy"}"`
`38`		`- respond(statusCode, DetailedHealthResponse(mongoDbStatus, postgresStatus, reason))`
	`37`	`+ respond(statusCode, DetailedHealthResponse(mongoDbStatus, postgresStatus))`
`39`	`38`	`}`
`40`	`39`
`41`	`40`	`suspend fun ApplicationCall.handleHealthError(error: HealthCheckError) {`
`@@ -114,4 +113,4 @@ private fun createDatabaseErrorResponse(`
`114`	`113`	`}`
`115`	`114`
`116`	`115`	`@Serializable`
`117`		`-data class DetailedHealthResponse(val mongodb: String, val postgres: String, val reason: String)`
	`116`	`+data class DetailedHealthResponse(val mongodb: String, val postgres: String, val reason: String? = null)`