refactor: replace MongoTestListener with MongoSupport for application record setup

Author: marc0der

src/test/kotlin/io/sdkman/broker/acceptance/HealthCheckAcceptanceSpec.kt

@@ -5,6 +5,7 @@ import io.kotest.matchers.shouldBe
 import io.ktor.client.request.get
 import io.ktor.http.HttpStatusCode
 import io.ktor.server.testing.testApplication
+import io.sdkman.broker.support.MongoSupport
 import io.sdkman.broker.support.MongoTestListener
 import io.sdkman.broker.support.TestDependencyInjection
 import io.sdkman.broker.support.configureAppForTesting
@@ -17,7 +18,7 @@ class HealthCheckAcceptanceSpec : ShouldSpec() {
     init {
         should("return 200 OK when database is healthy") {
             // given: an initialised database
-            MongoTestListener.setupValidAppRecord()
+            MongoSupport.setupValidAppRecord()
 
             // when: a GET request is made for "/meta/alive"
             testApplication {
@@ -56,7 +57,7 @@ class HealthCheckAcceptanceSpec : ShouldSpec() {
 
         should("return 503 Service Unavailable when database has invalid application record") {
             // given: an uninitialised database with an invalid application record
-            MongoTestListener.setupInvalidAppRecord()
+            MongoSupport.setupInvalidAppRecord()
 
             // when: a GET request is made for "/meta/alive"
             testApplication {

src/test/kotlin/io/sdkman/broker/adapter/secondary/persistence/MongoApplicationRepositoryIntegrationSpec.kt

@@ -5,6 +5,7 @@ import arrow.core.Some
 import io.kotest.core.spec.style.ShouldSpec
 import io.sdkman.broker.domain.model.Application
 import io.sdkman.broker.domain.repository.RepositoryError
+import io.sdkman.broker.support.MongoSupport
 import io.sdkman.broker.support.MongoTestListener
 import io.sdkman.broker.support.shouldBeLeftAnd
 import io.sdkman.broker.support.shouldBeRight
@@ -16,7 +17,7 @@ class MongoApplicationRepositoryIntegrationSpec : ShouldSpec({
 
     should("return application when record exists with valid alive status") {
         // given
-        MongoTestListener.setupValidAppRecord()
+        MongoSupport.setupValidAppRecord()
 
         // when
         val result = repository.findApplication()
@@ -40,7 +41,7 @@ class MongoApplicationRepositoryIntegrationSpec : ShouldSpec({
 
     should("return an error when application record has invalid alive status") {
         // given
-        MongoTestListener.setupInvalidAppRecord()
+        MongoSupport.setupInvalidAppRecord()
 
         // when
         val result = repository.findApplication()

src/test/kotlin/io/sdkman/broker/support/MongoSupport.kt

@@ -5,7 +5,7 @@ import org.bson.Document
 
 object MongoSupport {
     fun setupVersion(version: Version) {
-        val versionsCollection = MongoTestListener.database.getCollection("versions")
+        val versionsCollection = MongoTestListener.versionsCollection
         versionsCollection.insertOne(
             Document().apply {
                 put("candidate", version.candidate)
@@ -20,4 +20,16 @@ object MongoSupport {
             }
         )
     }
-}
+
+    // Sets up a valid application record
+    fun setupValidAppRecord() {
+        val applicationCollection = MongoTestListener.applicationCollection
+        applicationCollection.insertOne(Document("alive", "OK"))
+    }
+
+    // Sets up an invalid application record
+    fun setupInvalidAppRecord() {
+        val applicationCollection = MongoTestListener.applicationCollection
+        applicationCollection.insertOne(Document("alive", "NOT_OK"))
+    }
+}

src/test/kotlin/io/sdkman/broker/support/MongoTestListener.kt

@@ -4,7 +4,6 @@ import com.mongodb.MongoClient
 import io.kotest.core.listeners.TestListener
 import io.kotest.core.spec.Spec
 import io.kotest.core.test.TestCase
-import org.bson.Document
 import org.testcontainers.containers.MongoDBContainer
 import org.testcontainers.utility.DockerImageName
 
@@ -47,20 +46,8 @@ object MongoTestListener : TestListener {
     }
 
     // Resets the database to a clean state
-    fun resetDatabase() {
+    private fun resetDatabase() {
         applicationCollection.drop()
         versionsCollection.drop()
     }
-
-    // Sets up a valid application record
-    fun setupValidAppRecord() {
-        resetDatabase()
-        applicationCollection.insertOne(Document("alive", "OK"))
-    }
-
-    // Sets up an invalid application record
-    fun setupInvalidAppRecord() {
-        resetDatabase()
-        applicationCollection.insertOne(Document("alive", "NOT_OK"))
-    }
 }