-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Future changes
That said, I would suggest the following improvements for one/more separate PR:
- Write your common recipes (install, check, build) in the justfile ( it has placeholder comments for now).
- Make a dockerfile with all the tooling needed run CI (python + stuff in requirements.txt and
just)- could take inspiration from gimie-api, with
uv pip install -r requirements.txtinstead ofuv sync. - docker push said image manually.
- could take inspiration from gimie-api, with
- Run CI in docker image instead of manually pip installing stuff everytime.
- Replace all calls to script in CI with
just install,just check,just build.- now when we rename scripts / change the building process or whatever, we don't have to change every CI job, only the justfile.
Notes
With the current setup, the tools/{bash,python} folders kind of make sense because we have to store the requirements.txt.
Once we have a docker image containing the environment, I would do this:
tools
├── image
│ ├── Dockerfile
│ └── requirements.txt
└── scripts
├── build_ontology.sh
├── create_schemas.py
└── shacl_validation.py
Originally posted by @cmdoret in #12 (review)
Metadata
Metadata
Assignees
Labels
No labels