Skip to content

Commit d926df9

Browse files
author
宣源
committed
merge main
2 parents f69fb39 + 22a77e7 commit d926df9

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+5524
-306
lines changed

.github/ISSUE_TEMPLATE/1-bug-report.yml

Lines changed: 34 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -3,39 +3,38 @@ name: 🐞 Bug report
33
description: Create a report to help us reproduce and fix the bug
44
title: "[Bug] "
55
labels: ['Bug']
6-
76
body:
8-
- type: checkboxes
9-
attributes:
10-
label: Checklist
11-
options:
12-
- label: 1. I have searched for related issues and FAQs (https://github.com/mit-han-lab/nunchaku/blob/main/docs/faq.md) but was unable to find a solution.
13-
- label: 2. The issue persists in the latest version.
14-
- label: 3. Please note that without environment information and a minimal reproducible example, it will be difficult for us to reproduce and address the issue, which may delay our response.
15-
- label: 4. If your report is a question rather than a bug, please submit it as a discussion at https://github.com/mit-han-lab/ComfyUI-nunchaku/discussions/new/choose. Otherwise, this issue will be closed.
16-
- label: 5. I will do my best to describe the issue in English.
17-
- type: textarea
18-
attributes:
19-
label: Describe the Bug
20-
description: Provide a clear and concise explanation of the bug you encountered.
21-
validations:
22-
required: true
23-
- type: textarea
24-
attributes:
25-
label: Environment
26-
description: |
27-
Please include relevant environment details such as your system specifications, Python version, PyTorch version, and CUDA version.
28-
placeholder: "Example: Ubuntu 24.04, Python 3.11, PyTorch 2.6, CUDA 12.4"
29-
validations:
30-
required: true
31-
- type: textarea
32-
attributes:
33-
label: Reproduction Steps
34-
description: |
35-
Please provide clear, step-by-step instructions to help us reproduce the issue. Be as specific as possible. Include the following:
36-
- The ComfyUI workflow file (`.json`) you used, along with a screenshot of your workflow
37-
- Links to the models, LoRAs, and control components involved
38-
- The exact prompt(s) used
39-
- Any input images required by the workflow
40-
validations:
41-
required: true
7+
- type: checkboxes
8+
attributes:
9+
label: Checklist
10+
options:
11+
- label: 1. I have searched for related issues and FAQs (https://github.com/mit-han-lab/nunchaku/blob/main/docs/faq.md) but was unable to find a solution.
12+
- label: 2. The issue persists in the latest version.
13+
- label: 3. Please note that without environment information and a minimal reproducible example, it will be difficult for us to reproduce and address the issue, which may delay our response.
14+
- label: 4. If your report is a question rather than a bug, please submit it as a discussion at https://github.com/mit-han-lab/ComfyUI-nunchaku/discussions/new/choose. Otherwise, this issue will be closed.
15+
- label: 5. I will do my best to describe the issue in English.
16+
- type: textarea
17+
attributes:
18+
label: Describe the Bug
19+
description: Provide a clear and concise explanation of the bug you encountered.
20+
validations:
21+
required: true
22+
- type: textarea
23+
attributes:
24+
label: Environment
25+
description: |
26+
Please include relevant environment details such as your system specifications, Python version, PyTorch version, and CUDA version.
27+
placeholder: "Example: Ubuntu 24.04, Python 3.11, PyTorch 2.6, CUDA 12.4"
28+
validations:
29+
required: true
30+
- type: textarea
31+
attributes:
32+
label: Reproduction Steps
33+
description: |
34+
Please provide clear, step-by-step instructions to help us reproduce the issue. Be as specific as possible. Include the following:
35+
- The ComfyUI workflow file (`.json`) you used, along with a screenshot of your workflow
36+
- Links to the models, LoRAs, and control components involved
37+
- The exact prompt(s) used
38+
- Any input images required by the workflow
39+
validations:
40+
required: true

.github/ISSUE_TEMPLATE/2-feature-request.yml

Lines changed: 18 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,22 @@
22
name: 🚀 Feature request
33
description: Suggest an idea for this project
44
title: "[Feature] "
5-
65
body:
7-
- type: checkboxes
8-
attributes:
9-
label: Checklist
10-
options:
11-
- label: 1. If the issue you raised is not a feature but a question, please raise a discussion at https://github.com/mit-han-lab/ComfyUI-nunchaku/discussions/new/choose. Otherwise, it will be closed.
12-
- label: 2. I will do my best to describe the issue in English.
13-
- type: textarea
14-
attributes:
15-
label: Motivation
16-
description: |
17-
A clear and concise description of the motivation of the feature.
18-
validations:
19-
required: true
20-
- type: textarea
21-
attributes:
22-
label: Related resources
23-
description: |
24-
If there is an official code release or third-party implementations, please also provide the information here, which would be very helpful.
6+
- type: checkboxes
7+
attributes:
8+
label: Checklist
9+
options:
10+
- label: 1. If the issue you raised is not a feature but a question, please raise a discussion at https://github.com/mit-han-lab/ComfyUI-nunchaku/discussions/new/choose. Otherwise, it will be closed.
11+
- label: 2. I will do my best to describe the issue in English.
12+
- type: textarea
13+
attributes:
14+
label: Motivation
15+
description: |
16+
A clear and concise description of the motivation of the feature.
17+
validations:
18+
required: true
19+
- type: textarea
20+
attributes:
21+
label: Related resources
22+
description: |
23+
If there is an official code release or third-party implementations, please also provide the information here, which would be very helpful.

.github/workflows/auto-merge-main-into-dev.yml renamed to .github/workflows/auto-merge-main-into-dev.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,21 @@
11
name: Auto-merge main into dev
2-
32
on:
43
workflow_dispatch:
54
push:
65
branches:
76
- main
8-
97
permissions:
108
contents: write
11-
129
jobs:
1310
merge-main-into-dev:
1411
runs-on: ubuntu-latest
1512
if: github.repository == 'mit-han-lab/ComfyUI-nunchaku'
16-
1713
steps:
1814
- name: Checkout the repository
1915
uses: actions/checkout@v4
2016
with:
2117
fetch-depth: 0
2218
token: ${{ secrets.GH_TOKEN }}
23-
2419
- name: Check if main and dev are already in sync
2520
id: check_sync
2621
run: |
@@ -36,7 +31,6 @@ jobs:
3631
echo "Branches differ. Proceeding with merge."
3732
echo "skip_merge=false" >> "$GITHUB_OUTPUT"
3833
fi
39-
4034
- name: Merge main into dev
4135
id: last_commit
4236
if: steps.check_sync.outputs.skip_merge == 'false'

.github/workflows/close_inactive_issues.yaml renamed to .github/workflows/close-inactive-issues.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
11
# Borrowed from https://github.com/sgl-project/sglang/blob/main/.github/workflows/close-inactive-issues.yml
22
name: Close Inactive Issues
3-
43
on:
54
schedule:
65
- cron: '0 0 * * *'
76
workflow_dispatch:
8-
97
permissions:
108
issues: write
119
contents: read
12-
1310
jobs:
1411
close-inactive-issues:
1512
if: github.repository == 'mit-han-lab/ComfyUI-nunchaku'

.github/workflows/lint.yaml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
name: Lint
2-
32
on:
43
push:
54
branches:
@@ -15,34 +14,27 @@ on:
1514
options:
1615
- pr
1716
- branch
18-
1917
pr_number:
2018
description: 'Pull Request Number (only if test_target == "pr")'
2119
required: false
22-
2320
branch_name:
2421
description: 'Branch name (only if test_target == "branch")'
2522
default: 'main'
2623
required: false
27-
2824
jobs:
2925
lint:
3026
runs-on: ubuntu-latest
3127
steps:
3228
- uses: actions/checkout@v4
33-
3429
- name: Show current commit
3530
run: git log -1 --oneline
36-
3731
- name: Set up Python
3832
uses: actions/setup-python@v4
3933
with:
4034
python-version: '3.11'
41-
4235
- name: Install pre-commit hook
4336
run: |
4437
python -m pip install pre-commit
4538
pre-commit install
46-
4739
- name: Linting
4840
run: pre-commit run --all-files --show-diff-on-failure
Lines changed: 6 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
name: test_ampere
2-
1+
name: Ampere Tests
32
on:
43
workflow_dispatch:
54
inputs:
@@ -10,11 +9,9 @@ on:
109
options:
1110
- pr
1211
- branch
13-
1412
pr_number:
1513
description: 'Pull Request Number (only if test_target == "pr")'
1614
required: false
17-
1815
branch_name:
1916
description: 'Branch name (only if test_target == "branch")'
2017
default: 'main'
@@ -36,15 +33,13 @@ on:
3633
# issue_comment:
3734
# types: [ created ]
3835

39-
4036
concurrency:
4137
group: ${{ github.repository }}-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
4238
cancel-in-progress: true
43-
4439
jobs:
4540
check-comment:
4641
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'issue_comment' && github.event.issue.pull_request && !github.event.pull_request.draft) }}
47-
runs-on: [ self-hosted, ampere ]
42+
runs-on: [self-hosted, ampere]
4843
outputs:
4944
should_run: ${{ steps.check.outputs.should_run }}
5045
steps:
@@ -57,10 +52,9 @@ jobs:
5752
else
5853
echo "should_run=false" >> $GITHUB_OUTPUT
5954
fi
60-
6155
run-tests:
62-
runs-on: [ self-hosted, ampere ]
63-
needs: [ check-comment ]
56+
runs-on: [self-hosted, ampere]
57+
needs: [check-comment]
6458
if: ${{ github.event_name != 'issue_comment' || needs.check-comment.outputs.should_run == 'true' }}
6559
steps:
6660
- name: Determine ref
@@ -76,16 +70,13 @@ jobs:
7670
with:
7771
ref: ${{ steps.set-ref.outputs.ref }}
7872
submodules: true
79-
8073
- name: Show current commit
8174
run: git log -1 --oneline
82-
8375
- name: Set up Python
8476
run: |
8577
which python
8678
echo "Setting up Python with Conda"
8779
conda create -n test_env python=3.12 -y
88-
8980
- name: Install dependencies
9081
run: |
9182
source $(conda info --base)/etc/profile.d/conda.sh
@@ -95,7 +86,6 @@ jobs:
9586
echo "Installing dependencies"
9687
pip install torch torchvision torchaudio --index-url https://download.pytorch.org/whl/cu128
9788
pip install ninja wheel diffusers transformers accelerate sentencepiece protobuf huggingface_hub
98-
9989
- name: Install Nunchaku
10090
run: |
10191
source $(conda info --base)/etc/profile.d/conda.sh
@@ -113,7 +103,6 @@ jobs:
113103
git submodule init
114104
git submodule update
115105
NUNCHAKU_INSTALL_MODE=ALL python setup.py develop
116-
117106
- name: Install ComfyUI and set up test environment
118107
run: |
119108
source $(conda info --base)/etc/profile.d/conda.sh
@@ -137,7 +126,6 @@ jobs:
137126
comfy node install comfyui-inpainteasy
138127
HF_TOKEN=${{ secrets.HF_TOKEN }} python custom_nodes/ComfyUI-nunchaku/scripts/download_models.py
139128
HF_TOKEN=${{ secrets.HF_TOKEN }} python custom_nodes/ComfyUI-nunchaku/scripts/download_test_data.py
140-
141129
- name: Run tests
142130
run: |
143131
source $(conda info --base)/etc/profile.d/conda.sh
@@ -147,12 +135,10 @@ jobs:
147135
pwd
148136
python nunchaku_tests/scripts/nunchaku_flux1_dev.py
149137
pytest -v nunchaku_tests/
150-
151138
clean-up:
152139
if: always() && (github.event_name != 'issue_comment' || needs.check-comment.outputs.should_run == 'true')
153-
needs: [ run-tests ]
154-
runs-on: [ self-hosted, ampere ]
155-
140+
needs: [run-tests]
141+
runs-on: [self-hosted, ampere]
156142
steps:
157143
- name: Clean up
158144
run: |

0 commit comments

Comments
 (0)