fix: support hyphen in workflow variables

Author: alexcodelf

pkg/dao/workflow.go

@@ -353,7 +353,7 @@ func parseWorkflowVariables(
 		return nil, err
 	}
 
-	re := regexp.MustCompile(`\$\{\s*workflow\.var\.(\w+)\s*\}`)
+	re := regexp.MustCompile(`\$\{\s*workflow\.var\.([-\w]+)\s*}`)
 	replaced := re.ReplaceAllFunc(bs, func(s []byte) []byte {
 		name := re.FindSubmatch(s)[1]
 		name = bytes.TrimSpace(name)

pkg/dao/workflow_test.go

@@ -34,6 +34,41 @@ func TestParseParams(t *testing.T) {
 			},
 			wantError: false,
 		},
+		{
+			attributes: map[string]any{
+				"description": "${workflow.var.var-1}",
+			},
+			params: map[string]string{
+				"var-1": "aaa",
+			},
+			config: types.WorkflowVariables{
+				{
+					Name:      "var-1",
+					Value:     "alice",
+					Overwrite: true,
+				},
+			},
+			expected: map[string]any{
+				"description": "aaa",
+			},
+			wantError: false,
+		},
+		{
+			attributes: map[string]any{
+				"description": "${workflow.var.var-1}",
+			},
+			config: types.WorkflowVariables{
+				{
+					Name:      "var-1",
+					Value:     "alice",
+					Overwrite: false,
+				},
+			},
+			expected: map[string]any{
+				"description": "alice",
+			},
+			wantError: false,
+		},
 		{
 			attributes: map[string]any{
 				"deepAttr": map[string]any{