ci: run markdown formatting check via the Makefile target

The lint workflow duplicated the prettier invocation inline, so it could
drift from the Makefile, and the `lint.markdown` target was interactive
(prompted y/n) — unusable in CI and in scripts. It also probed a
misspelled `node_module` directory.

Collapse `lint.markdown` to a single non-interactive target that reformats
with prettier, sharing one `PRETTIER_ARGS` definition. CI now runs
`make lint.markdown` and fails on any resulting diff, so the workflow and
local formatting use the exact same rules.

Signed-off-by: Sean Chittenden <sean.chittenden@crowdstrike.com>

Author: sean-

.github/workflows/lint.yml

@@ -39,4 +39,6 @@ jobs:
       - name: Install dependencies
         run: npm i -g prettier
       - name: Check markdown files
-        run: prettier --prose-wrap never --print-width 300 --check "**/*.md"
+        run: |
+          make lint.markdown
+          git diff --exit-code || { echo "::error::Markdown files are not formatted. Run 'make lint.markdown' and commit the result."; exit 1; }

Makefile

@@ -249,40 +249,10 @@ lint.local:  ## Run lint locally (not in Docker) across all build-tag combinatio
 	cd cmd/osgen && golangci-lint run --fix --build-tags $(GOLANGCI_LINT_BUILD_TAGS) --timeout=5m -v ./...
 
 package := "prettier"
-lint.markdown:  ## Check markdown formatting with prettier (same check as CI)
-	@printf "\033[2m-> Checking node installed...\033[0m\n"
-	if type node > /dev/null 2>&1 && which node > /dev/null 2>&1 ; then \
-		node -v; \
-		echo -e "\033[33m Node is installed, continue...\033[0m\n"; \
-	else \
-		echo -e "\033[31m Please install node\033[0m\n"; \
-		exit 1; \
-	fi
-	@printf "\033[2m-> Checking npm installed...\033[0m\n"
-	if type npm > /dev/null 2>&1 && which npm > /dev/null 2>&1 ; then \
-		npm -v; \
-		echo -e "\033[33m NPM is installed, continue...\033[0m\n"; \
-	else \
-		echo -e "\033[31m Please install npm\033[0m\n"; \
-		exit 1; \
-	fi
-	@printf "\033[2m-> Checking $(package) installed...\033[0m\n"
-	if [ `npm list -g | grep -c $(package)` -eq 0 -o ! -d node_module ]; then \
-		echo -e "\033[33m Installing $(package)...\033[0m"; \
-		npm install -g $(package) --no-shrinkwrap; \
-	fi
-	@printf "\033[2m-> Running markdown lint...\033[0m\n"
-	if npx $(package) --prose-wrap never --print-width 300 --check "**/*.md"; [[ $$? -ne 0 ]]; then \
-		echo -e "\033[32m-> Found invalid files. Want to auto-format invalid files? (y/n) \033[0m"; \
-		read RESP; \
-		if [ "$$RESP" = "y" ] || [ "$$RESP" = "Y" ]; then \
-		  echo -e "\033[33m Formatting...\033[0m"; \
-		  npx $(package) --prose-wrap never --print-width 300 --write "**/*.md"; \
-		  echo -e "\033[34m \nAll invalid files are formatted\033[0m"; \
-		else \
-		  echo -e "\033[33m Skipping auto-format. CI will flag any remaining issues.\033[0m"; \
-		fi \
-	fi
+PRETTIER_ARGS := --prose-wrap never --print-width 300 "**/*.md"
+
+lint.markdown:  ## Reformat markdown files with prettier
+	npx $(package) $(PRETTIER_ARGS) --write
 
 
 backport: ## Backport one or more commits from main into version branches