style(opensearchtransport): extract clusterHealthName constant

Collapse the duplicated "cluster_health" literal (OperationID.String
label and discovery-flag map key) into one unexported constant, reused
across the package and internal tests. Clears the goconst threshold that
the new tests tripped and ties the token's uses together for tooling.

Signed-off-by: Sean Chittenden <sean.chittenden@crowdstrike.com>

Author: sean-

opensearchtransport/feature_config.go

@@ -175,7 +175,7 @@ func (f discoveryFeatures) nodeStatsEnabled() bool {
 var discoveryFlagNames = map[string]discoveryFeatures{
 	"cat_shards":         discoverySkipCatShards,
 	"routing_num_shards": discoverySkipRoutingNumShards,
-	"cluster_health":     discoverySkipClusterHealth,
+	clusterHealthName:    discoverySkipClusterHealth,
 	"node_stats":         discoverySkipNodeStats,
 }
 

opensearchtransport/observer_response_internal_test.go

@@ -182,7 +182,7 @@ func TestRequestEventIdentityFields(t *testing.T) {
 			name:          "system endpoint has empty index",
 			method:        http.MethodGet,
 			path:          "/_cluster/health",
-			wantRouteName: "cluster_health",
+			wantRouteName: clusterHealthName,
 			wantIndex:     "",
 			wantPath:      "/_cluster/health",
 		},

opensearchtransport/operation.go

@@ -612,6 +612,14 @@ const OpRenderSearchTemplate = CatSearch | minRenderSearchTemplate
 // OpPing identifies a cluster ping operation.
 const OpPing = CatPing | minPing
 
+// Operation name tokens shared between the [OperationID.String] labels and other
+// package sites that must spell the same wire token (e.g. discovery-flag names).
+// Extracting them keeps the spellings in lockstep and lets tooling trace every
+// use of a token back to one declaration.
+const (
+	clusterHealthName = "cluster_health"
+)
+
 // ---------------------------------------------------------------------------
 // String
 // ---------------------------------------------------------------------------
@@ -807,7 +815,7 @@ func (op OperationID) String() string {
 	case OpClusterInfo:
 		return "cluster_info"
 	case OpClusterHealth:
-		return "cluster_health"
+		return clusterHealthName
 	case OpClusterStats:
 		return "cluster_stats"
 	case OpClusterState: