Migrate API and plugin tests to context-aware calls

Replace nil and context.Background() with t.Context() throughout all API
and plugin test files to enable proper test timeout handling and allow Go's
test framework to clean up resources when tests are terminated or timeout.

Test improvements:
- opensearchapi: All 37 API test files migrated to t.Context()
- opensearchutil: JSON reader integration test updated
- plugins/ism: Policy and API tests migrated
- plugins/security: All 12 security plugin tests migrated

Context propagation enables proper test timeout handling, respects test
deadlines, and allows Go's test runner to perform cleanup when tests are
cancelled. This makes tests more resilient and easier to debug when they
fail or timeout.

Signed-off-by: Sean Chittenden <sean.chittenden@crowdstrike.com>

Author: sean-

CHANGELOG.md

@@ -7,6 +7,8 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 ### Added
 
 - Enhanced cluster readiness checking for improved test reliability: `ostest.NewClient()` now includes readiness validation (health + cluster state + nodes info)
+- Test parallelization support via TEST_PARALLEL environment variable (default: CPU cores - 1, minimum 1)
+- opensearchutil/testutil package with PollUntil helper for eventual consistency testing (ISM policies, index readiness, cluster state changes)
 - Configuration option `IncludeDedicatedClusterManagers` for controlling cluster manager node routing ([#765](https://github.com/opensearch-project/opensearch-go/issues/765))
 - Policy-based routing system for improved request routing and service availability ([#771](https://github.com/opensearch-project/opensearch-go/pull/771))
   - `Policy` interface for composable routing strategies with lifecycle management
@@ -26,17 +28,34 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 - Refactor Client struct to use embedded mutex pattern for improved thread safety ([#775](https://github.com/opensearch-project/opensearch-go/pull/775))
 - Refactor metrics struct to use atomic counters for lock-free request/failure tracking ([#776](https://github.com/opensearch-project/opensearch-go/pull/776))
 - Test against Opensearch 2.19.4, 3.1, 3.3, and 3.4 ([#782](https://github.com/opensearch-project/opensearch-go/pull/782))
+- Migrate all test files to context-aware API calls for proper timeout and cancellation support
+- Add cluster readiness validation and improve cluster error diagnostics
+- Update Docker cluster management to add version-aware role detection (cluster_manager vs master)
+- Generate unique document IDs in tests for parallel test execution and eliminate known test flakes
+- Reduce integration test timeout from 1h to 10m per package with parallel execution support
+- Refactor transport code for improved maintainability (rename ErrInvalidRole -> InvalidRoleError, add response body cleanup, simplify initialization)
 - **BREAKING**: Enhanced node discovery to match OpenSearch server behavior ([#765](https://github.com/opensearch-project/opensearch-go/issues/765))
   - Dedicated cluster manager nodes are now excluded from client request routing by default (best practice)
   - Node selection logic now matches Java client `NodeSelector.SKIP_DEDICATED_CLUSTER_MASTERS` behavior
+- **BREAKING**: Add context support to discovery and client lifecycle management
+  - `opensearchtransport.Discoverable` interface now requires `context.Context` parameter: `DiscoverNodes(ctx context.Context) error`
+  - `opensearch.Client.DiscoverNodes()` and `opensearchtransport.Client.DiscoverNodes()` now require `context.Context` parameter
+  - `opensearch.Config` and `opensearchtransport.Config` now accept optional `Context` and `CancelFunc` fields
+  - `opensearchutil.BulkIndexerConfig` now accepts optional `Context` and `CancelFunc` fields
+  - Enables proper context propagation for timeouts, cancellation, and graceful shutdown
 
 ### Deprecated
 
 ### Removed
 
 ### Fixed
 
+- Fix connection lifecycle bug in statusConnectionPool.OnFailure where connections were scheduled for resurrection before being moved from live to dead list, causing potential race conditions
 - Fix flaky connection integration test by replacing arbitrary sleep times with proper server readiness polling
+- Fix cluster readiness checks in integration tests to handle HTTPS cold start delays (increase timeout to 15s)
+- Fix GitHub Actions workflow authentication for OpenSearch 2.12.0+ password changes (admin -> myStrongPassword123!)
+- Fix Docker cluster management to properly handle version-specific configurations and clean stale images/volumes
+- Fix OpenSearch 2.8.0+ Tasks API compatibility by adding cancellation_time_millis field to TasksListTask struct
 - Fix OpenSearch 3.1.0+ API compatibility by adding phase_results_processors field to nodes API and time_in_execution fields to cluster pending tasks API
 - Fix OpenSearch 3.2.0+ API compatibility by adding max_last_index_request_timestamp and startree query fields across nodes stats, indices stats, and cat APIs, plus settings field to security plugin health API
 - Fix OpenSearch 3.3.0+ API compatibility by adding neural_search breaker, query_failed and startree_query_failed search fields, search pipeline system_generated fields across multiple APIs, plus ingestion_status field to cluster state API and jwks_uri field to security config API

opensearchapi/api_aliases_test.go

@@ -17,26 +17,30 @@ import (
 	ostest "github.com/opensearch-project/opensearch-go/v4/internal/test"
 	"github.com/opensearch-project/opensearch-go/v4/opensearchapi"
 	osapitest "github.com/opensearch-project/opensearch-go/v4/opensearchapi/internal/test"
+	"github.com/opensearch-project/opensearch-go/v4/opensearchutil/testutil"
 )
 
 func TestAliases(t *testing.T) {
 	t.Run("Aliases", func(t *testing.T) {
 		client, err := ostest.NewClient(t)
 		require.Nil(t, err)
 
-		index := "test-aliases"
+		index := testutil.MustUniqueString(t, "test-aliases")
 		t.Cleanup(func() {
-			client.Indices.Delete(nil, opensearchapi.IndicesDeleteReq{Indices: []string{index}})
+			client.Indices.Delete(t.Context(), opensearchapi.IndicesDeleteReq{Indices: []string{index}})
 		})
 
-		_, err = client.Indices.Create(nil, opensearchapi.IndicesCreateReq{Index: index})
+		_, err = client.Indices.Create(t.Context(), opensearchapi.IndicesCreateReq{Index: index})
 		require.Nil(t, err)
 
 		t.Run("with request", func(t *testing.T) {
 			resp, err := client.Aliases(
-				nil,
+				t.Context(),
 				opensearchapi.AliasesReq{
-					Body: strings.NewReader(`{"actions":[{"add":{"index":"test-aliases","alias":"logs"}},{"remove":{"index":"test-aliases","alias":"logs"}}]}`),
+					Body: strings.NewReader(
+						`{"actions":[{"add":{"index":"` + index + `","alias":"logs"}},` +
+							`{"remove":{"index":"` + index + `","alias":"logs"}}]}`,
+					),
 				},
 			)
 			require.Nil(t, err)
@@ -49,7 +53,7 @@ func TestAliases(t *testing.T) {
 			failingClient, err := osapitest.CreateFailingClient()
 			require.Nil(t, err)
 
-			res, err := failingClient.Aliases(nil, opensearchapi.AliasesReq{})
+			res, err := failingClient.Aliases(t.Context(), opensearchapi.AliasesReq{})
 			require.NotNil(t, err)
 			require.NotNil(t, res)
 			osapitest.VerifyInspect(t, res.Inspect())

opensearchapi/api_bulk_test.go

@@ -27,7 +27,7 @@ func TestBulkClient(t *testing.T) {
 
 	index := "test-bulk"
 	t.Cleanup(func() {
-		client.Indices.Delete(nil, opensearchapi.IndicesDeleteReq{Indices: []string{index}})
+		client.Indices.Delete(t.Context(), opensearchapi.IndicesDeleteReq{Indices: []string{index}})
 	})
 
 	tests := []struct {
@@ -45,7 +45,12 @@ func TestBulkClient(t *testing.T) {
 			Name: "without index",
 			Request: opensearchapi.BulkReq{
 				Body: strings.NewReader(
-					fmt.Sprintf("{\"index\": {\"_index\": \"%s\"}}\n{\"test\": 1234}\n{\"create\": {\"_index\": \"%s\"}}\n{\"test\": 5678}\n", index, index),
+					fmt.Sprintf(
+						"{\"index\": {\"_index\": \"%s\"}}\n{\"test\": 1234}\n"+
+							"{\"create\": {\"_index\": \"%s\"}}\n{\"test\": 5678}\n",
+						index,
+						index,
+					),
 				),
 			},
 		},
@@ -54,7 +59,7 @@ func TestBulkClient(t *testing.T) {
 	for _, test := range tests {
 		t.Run(test.Name, func(t *testing.T) {
 			res, err := client.Bulk(
-				nil,
+				t.Context(),
 				test.Request,
 			)
 			require.Nil(t, err)
@@ -66,7 +71,7 @@ func TestBulkClient(t *testing.T) {
 		failingClient, err := osapitest.CreateFailingClient()
 		require.Nil(t, err)
 
-		res, err := failingClient.Bulk(nil, opensearchapi.BulkReq{Index: index})
+		res, err := failingClient.Bulk(t.Context(), opensearchapi.BulkReq{Index: index})
 		assert.NotNil(t, err)
 		assert.NotNil(t, res)
 		osapitest.VerifyInspect(t, res.Inspect())