macros to help using warp

[kdy1]

I wrote macros to ease using warp, and I'm considering merging macros back into warp.

See rweb/tests and rweb/examples to see usage examples.

[carllerche]

This is pretty cool. I didn’t see any examples of using the macros and passing around application state. Do you have one?

[kdy1]

@carllerche I'm sorry, but I'm not sure what did you mean by state. (I'm not English native)
Did you mean something like a db in

warp/examples/todos.rs

Lines 39 to 46 in 2823891

	pub fn todos(
	db: Db,
	) -> impl Filter<Extract = impl warp::Reply, Error = warp::Rejection> + Clone {
	todos_list(db.clone())
	.or(todos_create(db.clone()))
	.or(todos_update(db.clone()))
	.or(todos_delete(db))
	}

or something like hb in

warp/examples/handlebars_template.rs

Lines 51 to 54 in 2823891

	.map(|| WithTemplate {
	name: "template.html",
	value: json!({"user" : "Warp"}),
	})

If you meant the latter, it's implemented as #[filter = "foo_path"].

Anyway, I'm going to add #[data] which allows passing an argument from caller to actual handler.

[kdy1]

I've implemented #[data], which allows passing datas down. I'll update tests and examples

[seanmonstar]

This is really cool! It sounds similar to what Carl wanted to do with tower-web. I've always wanted warp to provide its FP-style Filter API, but some people really like the attribute style.

We could add a warp-macros crate that people can add if they prefer that style...

[jxs]

hi @kdy1 , have you seen tower-web? I think what @carllerche meant was something like tower-web's impl_web! macro where you would define a struct to agregate state across handlers, which would then ored and passed to warp::serve

[davidbarsky]

I would absolutely love to have the macros in rweb in warp. A warp-macros crate would be excellent.

[kdy1]

I added automatic openapi spec genertion to rweb, and I'm not sure if it would be useful for warp. As macro removes attributes, there's no way to make openapi related code act as 3rd-party library. I mean, openapi annotation should be handled by macros like #[get("/")].

Anyway, I want to hear more opinion about it.

[kdy1]

hi @kdy1 , have you seen tower-web? I think what @carllerche meant was something like tower-web's impl_web! macro where you would define a struct to agregate state across handlers, which would then ored and passed to warp::serve

I were not aware of it. But rweb supports it via #[data]. You can pass down e.g. db struct to handlers.

[kdy1]

@seanmonstar What's your opinion about openapi spec generator? Do you think it can be feature of warp?

If not, I should redesign rweb-macros to be usable with warp.