Update from 1.X (Craft 3) to 2.X (Craft 4) results in Deprecation Error

[maxstrebel]

Hi, I'm currently updating a Craft 3 project to Craft 4. After upgrading (by filling in the recommended versions in package.json) I got a deprecation notice which references https://github.com/sebastian-lenz/craft-linkfield/issues/122.

After some research, I found out that there's a v2 for quite some time, which changes the namespace from typedlinkfield\fields\LinkField to lenz\linkfield\fields\LinkField. As this never showed up as Update, I am still on v1. The migration that does the change will not be run in Craft 4 (due to the deprecation notice). So what you would have to do is:

1. Update to 2.0.0-rc.2 in Craft 3
2. Run the migrations
3. Do a project-config/rebuild
4. Update to Craft 4

No problem to do that, but I guess it might help to have some documentation if this is the upgrade path. Or there should be some kind of upgrade path from Craft 3 v1 to Craft4 v2. Sorry that I'm not knowledgeable enough to create a pull-request for a solution.

[darylknight]

I've just updated to Craft 4 and am also seeing this deprecation notice. It's no longer possible to update to Link Field 2.x in Craft 3, so you can't follow the steps above (as far as I remember, it was available for a couple of weeks until the versions were fixed and it was taken down again).

Seeing this in Craft 4.0.5 and Link Field 2.1.3-rc

[sebastian-lenz]

Hm, there must be more to your issues, the deprecation message should not stop the migration from running. It's just an informal message that's recorded for you in the control panel. At least that's how I understand it and if I'm wrong I'll remove the deprecation warning immediately.

@maxstrebel Did you encounter any other errors?

@darylknight Did you rebuild the project configuration as suggested? That's the primary reason as of why that message exists.

[darylknight]

From what I remember, I think rebuilding the config fixed it, yes thank you

[maxstrebel]

@sebastian-lenz unfortunately I cannot reproduce it now.

I guess it threw an error for me because I was still in $HARD_MODE (which throws an error when Craft encounters a deprecation warning)

[RyanRoberts]

I've just updated to Craft 4 and am also seeing this deprecation notice. It's no longer possible to update to Link Field 2.x in Craft 3, so you can't follow the steps above (as far as I remember, it was available for a couple of weeks until the versions were fixed and it was taken down again).

Seeing this in Craft 4.0.5 and Link Field 2.1.3-rc

I'm seeing the same issue as your screenshot but rebuilding the config isn't making it go away 🤔

[ctangney-tulip]

Updating this thread with some information collected in the thread for #122 --

... digging into the .yaml revealed that the type for these fields had not been reset. Immediately, we grew suspicious of the migration file m190417_202153_migrateDataToTable.php -- specifically lines 64, 66, and 72.

Performing this query against our database (SELECT * from TABLE where type = 'typedlinkfield\fields\LinkField';) returned 0 records as a result of the unescaped back slashes. Properly escaping the back slashes and performing the query again returned the correct / expected result.

After updating these lines in the migration file, and re-running the migration for this plugin, the deprecation warning in the Craft Admin UI is no longer present, and all .yaml files have had their type properly reset.

This process was successfully tested against multiple developer's machines.

I will be opening a PR with a fix for this issue this afternoon 👍

@RyanRoberts @darylknight @sebastian-lenz @maxstrebel

[ctangney-tulip]

FWIW, another developer and I have also begun to suspect that this may have some relation to the issues experienced while trying to migrate link fields stored in Super Tables.

[ctangney-tulip]

#245