Skip to content

Commit 59c1b11

Browse files
adams85lahma
andauthored
AstVisitor corrections (#239)
* Add missing visitation of ExportAllDeclaration.Exported * Remove AstVisitor.VisitStaticBlock as it is redundant * Code style consistency Co-authored-by: Marko Lahma <[email protected]>
1 parent 5d45a8b commit 59c1b11

File tree

2 files changed

+7
-18
lines changed

2 files changed

+7
-18
lines changed

src/Esprima/Ast/StaticBlock.cs

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,9 @@
1-
using Esprima.Utils;
2-
3-
namespace Esprima.Ast
1+
namespace Esprima.Ast
42
{
53
public sealed class StaticBlock : BlockStatement
64
{
75
public StaticBlock(in NodeList<Statement> body) : base(body, Nodes.StaticBlock)
86
{
97
}
10-
11-
protected internal override void Accept(AstVisitor visitor)
12-
{
13-
visitor.VisitStaticBlock(this);
14-
}
158
}
169
}

src/Esprima/Utils/AstVisitor.cs

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -315,6 +315,11 @@ protected internal virtual void VisitExportDefaultDeclaration(ExportDefaultDecla
315315

316316
protected internal virtual void VisitExportAllDeclaration(ExportAllDeclaration exportAllDeclaration)
317317
{
318+
if (exportAllDeclaration.Exported is not null)
319+
{
320+
Visit(exportAllDeclaration.Exported);
321+
}
322+
318323
Visit(exportAllDeclaration.Source);
319324
}
320325

@@ -345,7 +350,7 @@ protected internal virtual void VisitExportSpecifier(ExportSpecifier exportSpeci
345350

346351
protected internal virtual void VisitImport(Import import)
347352
{
348-
if (import.Source != null)
353+
if (import.Source is not null)
349354
{
350355
Visit(import.Source);
351356
}
@@ -588,14 +593,5 @@ protected internal virtual void VisitBlockStatement(BlockStatement blockStatemen
588593
Visit(body[i]);
589594
}
590595
}
591-
592-
protected internal virtual void VisitStaticBlock(StaticBlock blockStatement)
593-
{
594-
ref readonly var body = ref blockStatement.Body;
595-
for (var i = 0; i < body.Count; i++)
596-
{
597-
Visit(body[i]);
598-
}
599-
}
600596
}
601597
}

0 commit comments

Comments
 (0)