Skip to content

Commit 317f60c

Browse files
committed
Prepare for the 1.2.4 release
1 parent 4337eb2 commit 317f60c

File tree

5 files changed

+13
-8
lines changed

5 files changed

+13
-8
lines changed

.idea/gradle.xml

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@
44

55
## [Unreleased]
66

7+
### Added
8+
9+
- Support for Rider 2025.2 EAP 2
10+
711
## [1.2.3] - 2025-05-28
812

913
### Added

gradle.properties

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,19 @@ pluginNamespace = MSBuild.DevKit
66
dotnetBuildConfiguration = Debug
77
pluginRepositoryUrl = https://github.com/seclerp/rider-msbuild-devkit
88
# SemVer format -> https://semver.org
9-
pluginVersion = 1.2.3
9+
pluginVersion = 1.2.4
1010

1111
# Supported build number ranges and IntelliJ Platform versions -> https://plugins.jetbrains.com/docs/intellij/build-number-ranges.html
12-
pluginSinceBuild = 251
13-
pluginUntilBuild = 251.*
12+
pluginSinceBuild = 252
13+
pluginUntilBuild = 252.*
1414

1515
# IntelliJ Platform Properties -> https://plugins.jetbrains.com/docs/intellij/tools-gradle-intellij-plugin.html#configuration-intellij-extension
1616
platformType = RD
1717
# Possible values (minor is omitted):
1818
# Release: 2020.2
1919
# Nightly: 2020.3-SNAPSHOT
2020
# EAP: 2020.3-EAP2-SNAPSHOT
21-
platformVersion = 2025.1
21+
platformVersion = 2025.2-EAP2-SNAPSHOT
2222

2323
# Gradle Releases -> https://github.com/gradle/gradle/releases
2424
gradleVersion = 8.13

src/main/kotlin/me/seclerp/msbuild/devkit/run/MSBuildExecutorFactory.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import com.jetbrains.rd.util.lifetime.Lifetime
1010
import com.jetbrains.rider.run.RiderRunBundle
1111
import com.jetbrains.rider.run.configurations.AsyncExecutorFactory
1212
import com.jetbrains.rider.run.configurations.dotNetExe.DotNetExeConfigurationExtension
13+
import com.jetbrains.rider.run.configurations.exe.ProcessExecutionDetails
1314
import com.jetbrains.rider.run.configurations.project.DotNetProjectExecutorFactory
1415
import com.jetbrains.rider.run.configurations.tryCreateReSharperHostSelfDebugState
1516
import com.jetbrains.rider.run.environment.withDetectedExecutableType
@@ -21,7 +22,7 @@ class MSBuildExecutorFactory(private val parameters: MSBuildConfigurationParamet
2122
private val logger = getLogger<DotNetProjectExecutorFactory>()
2223

2324
override suspend fun create(executorId: String, environment: ExecutionEnvironment, lifetime: Lifetime): RunProfileState {
24-
val dotNetExecutable = parameters.toDotNetExecutable().withDetectedExecutableType()
25+
val dotNetExecutable = parameters.toDotNetExecutableSuspending(ProcessExecutionDetails.Default).withDetectedExecutableType()
2526
val project = environment.project
2627
val runtimeToExecute = DotNetRuntime.detectRuntimeForExeOrThrow(
2728
project,

src/main/kotlin/me/seclerp/msbuild/devkit/run/configurations/MSBuildConfigurationParameters.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import com.intellij.openapi.project.Project
44
import com.intellij.openapi.util.JDOMExternalizerUtil
55
import com.jetbrains.rider.run.configurations.RunConfigurationHelper
66
import com.jetbrains.rider.run.configurations.dotNetExe.DotNetExeConfigurationParameters
7+
import com.jetbrains.rider.run.configurations.exe.ProcessExecutionDetails
78
import com.jetbrains.rider.runtime.DotNetExecutable
89
import com.jetbrains.rider.runtime.DotNetRuntimeType
910
import org.jdom.Element
@@ -39,8 +40,8 @@ class MSBuildConfigurationParameters(
3940
private const val PROJECT_FILE_PATH = "PROJECT_FILE_PATH"
4041
}
4142

42-
override fun toDotNetExecutable(): DotNetExecutable {
43-
val base = super.toDotNetExecutable()
43+
override suspend fun toDotNetExecutableSuspending(details: ProcessExecutionDetails): DotNetExecutable {
44+
val base = super.toDotNetExecutableSuspending(details)
4445
// TODO: Generate MSBuild executable
4546
val parameters = buildList {
4647
add(projectFilePath)

0 commit comments

Comments
 (0)