Material Editor Lockup - Save As on material stored in an object's Contents.

[minerjr]

Environment

Second Life Release 26.2.0.25386466510 (64bit)
Release Notes

CPU: 12th Gen Intel(R) Core(TM) i7-12700K (3609.6 MHz)
Memory: 32463 MB
OS Version: Microsoft Windows 11 64-bit (Build 26200.8524)
Graphics Card Vendor: ATI Technologies Inc.
Graphics Card: AMD Radeon RX 6600

Windows Graphics Driver Version: 32.0.21043.12001
OpenGL Version: 4.6.0 Core Profile Context 26.6.1.260520

Window size: 1920x1009
Font Size Adjustment: 96pt
UI Scaling: 1
Draw distance: 256m
Bandwidth: 10000kbit/s
LOD factor: 2
Render quality: 6
Texture memory: 8146MB
Disk cache: Max size 3494.4 MB (100.0% used)

J2C Decoder Version: KDU v8.4.1
Audio Driver Version: OpenAL, version 1.1 ALSOFT 1.24.2 / OpenAL Community / OpenAL Soft: OpenAL Soft
Dullahan: 1.24.0.202510081738
CEF: 139.0.40+g465474a+chromium-139.0.7258.139
Chromium: 139.0.7258.139
LibVLC Version: 3.0.21
Voice Server Version:

June 05 2026 01:53:54

Description

If you open a that is stored inside of an object you own with the Build Window. If you press the Save As button and type in a name or keep it the same, the Material Editor will disable itself, then attempt to use the copy_inventory_item message which instantly fails. This causes the callback function to not respond and the UI becomes visible but the user cannot interact with it.

It seems that the copy_inventory_item message may have been changed on the server side if this feature ever worked. It seems to act as if the command is invalid with an non avatar's inventory as the parent.

One possible fix is to update the setCanSaveAs() method to disable the Save As button

Reproduction steps

1. Right click on an owned object and pick Build.
2. Click on the Contents tab.
3. Open your avatar's inventory.
4. Create a new material, does not need any textures applied.
5. Move the new material to the object's Contents panel with drag and drop.
6. Double click on the new material.
7. Once the window is open, click on the Save As button.
8. Can either keep the name or give a new name in the pop up.
9. Press the OK button.
10. Now the Material Editor window will be disabled, but visible.
11. Try to click on any of the buttons, the clicks will not register, but will interact with objects hidden behind the UI elements.
12. To prove this, turn the camera so an item it behind the Material Editor and try to click on the UI element and see if the interaction changes to the object instead.

[minerjr]

Here is an example fix that will disable the Save As button if the New Material is not in the Agent Inventory.

llmaterialeditor.cpp

void LLMaterialEditor::setCanSaveAs(bool value)
{
//
// If the object that is used by the Material Editor is on the global list of object's it is not from the user's avatar's inventory, so then
if (gObjectList.findObject(mObjectUUID))
{
// Disable the Save As button as the command copy_inventory_item fails if the parent ID is an object and not
// the user's inventory or owned folder.
childSetEnabled("save_as", false);
return;
}
//
if (!mIsOverride)
{
childSetEnabled("save_as", value);
}
}

Though fixing the message on the server side may be the correct fix

[akleshchev]

Though fixing the message on the server side may be the correct fix

Server does need to be fixed, but viewer also should react to the failure, not lock the material.

[minerjr]

The Save feature still works, just not saving as a different name on the Inventory. The Save still works due to using a different set of commands that change the texture assigned to the existing item and not copying an item. That seems to be the root cause of the issue.

My suggestion was to just disable the Save As button, but leave the Save button functional.

The other thing could be keep the Save As functional, but don't send the message but instead present an alert message to the user to let them know this feature is not working. I tried to do this, but the way the failure works, the OK button is pressed on the rename prompt, it is flagged as cancelled. So you could have an alert on the cancel flag and unlock the UI. But the issue is if you hit Cancel button, the same flag is pressed and will get the alert message stating that there was an error. If you can differentiate between the force cancel and Cancel button press, it would make it easier to just have an prompt message about the error. I was having issues trying to find a good way of determine if the cancel came from an error or user defined action.

[akleshchev]

My suggestion was to just disable the Save As button, but leave the Save button functional.

The problem is in lack of mObjectUUID handling. When we are dialing with a 'task' inventory we are supposed to copy the item to normal inventory first, like it's done for a notecard.

Edit: Not sure if it's a good idea. But seems reliable enough. #5908