enhance crypto ops with algorithm-aware sizing and comprehensive tests

[oeqqwq]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @oeqqwq, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces significant enhancements to the cryptographic enc and dec operations by making them algorithm-aware. Previously, these operations assumed a fixed overhead, but now they dynamically adjust output sizes based on the specified encryption algorithm, such as AES-CTR, AES-GCM, or SM4-GCM. This change improves the flexibility and correctness of cryptographic data handling by accurately accounting for algorithm-specific overheads. The update also includes a comprehensive suite of new tests to ensure the reliability and proper functioning of these enhanced operations across various scenarios.

Highlights

• Algorithm-Aware Sizing: The enc and dec cryptographic operations now dynamically calculate output sizes based on the specified encryption algorithm (e.g., "aes-ctr", "aes-gcm", "sm4-gcm") and its associated overhead.
• Refactored Crypto Operations: enc and dec have been refactored from simple_op to op_def, enabling them to return PFunction objects that store the chosen algorithm as an attribute for backend use.
• New Overhead Calculation Utility: A private helper function, _get_algo_overhead, was introduced to centralize the logic for determining ciphertext overhead for different algorithms.
• Enhanced Input Validation: The dec operation now includes more robust input validation, ensuring that the ciphertext length meets the minimum requirements for the specified decryption algorithm.
• Comprehensive Test Coverage: A new test file (tests/ops/test_crypto.py) has been added, providing extensive unit tests for the enc and dec operations, covering various algorithms, dynamic length scenarios, type checks, and roundtrip consistency.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enhances the crypto operations by introducing algorithm-aware sizing for encryption and decryption, along with comprehensive tests to ensure the correctness of the new features. The changes include a new function to determine the overhead of different encryption algorithms and modifications to the enc and dec functions to handle algorithm-specific sizing. Additionally, a new test file has been added to thoroughly test the new functionalities.

[tongke6]

LGTM