Dead code sweep: delete the storyboard-era leftovers (UI modernization PR 1)

Deletes 13 files with zero callers: the pre-PermissionManager permission
system (CameraAccess), an orphaned IBOutlet controller whose xib is long
gone (RolePickerOptionController), stubs (PopoverController, TorchTest,
empty UIOrientationHelpers), unused UIKit extensions (CGImage, UIView,
UIButton, UIViewController), the old ObjC frame path
(UIImage+ImageProcessing), and two empty test bridging headers. Trims
dead members from OrientationUtils and UIImage+gif.

UIImage+ImageProcessing.h was silently providing UIKit to every Swift
file in the target via the bridging header; 10 files now import UIKit
explicitly.

Adds Docs/UI_MODERNIZATION.md with the full inventory and PR sequence,
and fixes stale storyboard claims in CLAUDE.md.

348/348 tests pass.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: darioalessandro

CLAUDE.md

@@ -71,13 +71,14 @@ When adding new remote commands, you **must** implement `NSCoding` (`encode`/`in
 
 ### UI Architecture
 
-The app is migrating from UIKit (Storyboards) to SwiftUI:
-- **DeviceScannerViewController** — UIKit + Storyboard, entry point
-- **RolePickerController** — UIKit, role selection after connection
-- **CameraViewController** — UIKit, manages `AVCaptureSession` for the camera device
-- **MonitorViewController** — UIKit host that embeds `MonitorView` (SwiftUI) via `UIHostingController`
-- **MonitorView / MonitorViewModel** — SwiftUI view and ObservableObject view model for the monitor UI
-- **CameraViewModel** — ObservableObject for camera-side progress overlays
+The app is migrating from UIKit to SwiftUI (no storyboards or xibs remain; the window is built programmatically in `SceneDelegate`). See `Docs/UI_MODERNIZATION.md` for the migration plan. Most screens are SwiftUI views hosted by thin UIKit shells via `UIHostingController`:
+- **WelcomeViewController** — entry point (root of the nav controller), hosts `WelcomeView`
+- **RolePickerController** — role selection, hosts `RolePickerView`; also declares `RemoteCamSystem.shared`
+- **DeviceScannerViewController** — peer discovery, hosts `DeviceScannerView`; owns the actor lifecycle
+- **MonitorViewController** — hosts `MonitorView`; also defines `MonitorActor`
+- **CameraViewController** — pure UIKit, manages `AVCaptureSession` for the camera device (no SwiftUI view yet)
+- **WatchRemoteCameraController** — Watch-remote mode, embeds `CameraViewController` as a child
+- View models (`WelcomeViewModel`, `DeviceScannerViewModel`, `MonitorViewModel`, `CameraViewModel`) are ObservableObjects bridging actors to SwiftUI
 
 The `^{ }` prefix operator (defined in Theater) dispatches a closure to the main thread — you'll see it used extensively for UI updates from actor message handlers.
 

Docs/UI_MODERNIZATION.md

@@ -0,0 +1,99 @@
+# UI Modernization Plan
+
+Companion to [MODERNIZATION.md](MODERNIZATION.md) (Theater/actor removal). That doc is about
+the concurrency layer; this one is about the UI layer: killing the last UIKit shells,
+Objective-C files, and dead code left over from the storyboard era.
+
+Each PR below is a small, independently shippable slice. The **worklog** at the bottom
+collects raw material (numbers, before/after, war stories) for a blog post about
+modernizing this app with Claude (Fable).
+
+## Where the app actually is (inventory, 2026-07-05)
+
+Better than expected:
+
+- **Zero storyboards, zero xibs.** Launch screen is the `UILaunchScreen` plist dict.
+- **UIScene lifecycle fully adopted**; `AppDelegate` is minimal, window built in `SceneDelegate`.
+- **Deprecated-API greps come back clean**: no `keyWindow`, `statusBarOrientation`,
+  `UIAlertView`, `AVCaptureStillImageOutput`, `openURL(_:)`.
+- **Four of five screens are already SwiftUI**, hosted by thin UIKit shells:
+  `WelcomeView`, `RolePickerView`, `DeviceScannerView`, `MonitorView`.
+
+What's left:
+
+| Surface | Size | Blocker |
+|---|---|---|
+| Dead code (old permission system, orphaned IB controller, stubs, unused extensions) | ~10 files | none — delete |
+| Objective-C: `CPSoundManager`, `RCTimer` (+ app bridging header) | 3 files | none — trivial ports |
+| UIKit shells: `WelcomeViewController`, `RolePickerController` | ~320 lines | thin coordinators |
+| `DeviceScannerViewController` | 367 lines | owns actor lifecycle; is `ViewCtrlActor<Self>` target |
+| `MonitorViewController` + glue | ~820 lines | `MonitorActor: ViewCtrlActor<MonitorViewController>` calls the concrete VC |
+| `CameraViewController` | 1729 lines | AVFoundation capture graph; no SwiftUI view exists |
+| `WatchRemoteCameraController` | 322 lines | embeds CameraViewController as child |
+
+The structural blocker for the hard tier is Theater's `ViewCtrlActor<ConcreteVC>` generic
+binding — actors are type-welded to UIKit view controllers. That work overlaps with
+MODERNIZATION.md Phases 4–5.
+
+## PR sequence
+
+### PR 1: Dead code sweep — **this PR**
+Pure deletion, no behavior change.
+
+Files deleted (all verified zero callers):
+- `CameraAccess.swift` — the pre-`PermissionManager` permission system, entirely superseded
+- `RolePickerOptionController.swift` — IBOutlet controller whose xib died long ago
+- `PopoverController.swift` — SwiftUI "Hello, World!" stub
+- `TorchTest.swift` — diagnostic scaffolding
+- `UIOrientationHelpers.swift` — literally empty (header comment + import)
+- `CGImage.swift` — unused `rotated(by:)`
+- `UIViewController.swift` — unused child-VC helpers (call sites use `addChild` directly)
+- `UIButton.swift` — `styleButton`, only caller was `RolePickerOptionController`
+- `UIView.swift` — `roundCorners`/`styleEmbeddedView`, only caller was `styleButton`
+- `UIImage+ImageProcessing.h/.m` — old ObjC frame path, replaced by `JPEGFrameEncoder`/`HEICFrameEncoder`
+- `RemoteShutterTests-Bridging-Header.h`, `RemoteShutterUITests-Bridging-Header.h` — empty
+
+Members trimmed from live files:
+- `OrientationUtils`: `transformToUIKit`, `transformToUIImage`, `transformOrientationToImage`
+- `UIImage+gif`: `gifImageWithURL`
+
+Plus: drop `UIImage+ImageProcessing.h` from the app bridging header, clear the test
+targets' `SWIFT_OBJC_BRIDGING_HEADER` settings, fix stale storyboard claims in CLAUDE.md.
+
+### PR 2: Retire the Objective-C
+Port `CPSoundManager` (countdown beeps, `AVAudioPlayer`) and `RCTimer`
+(recursive-`dispatch_after` countdown) to small Swift types; delete
+`RemoteCam-Bridging-Header.h`. Zero ObjC left in the app target.
+
+### PR 3: Collapse the easy shells
+Delete `iAdViewController` (empty base class), fold `WelcomeViewController` down,
+slim `RolePickerController`; move the `RemoteCamSystem.shared` declaration out of it.
+
+### PR 4: Decouple actors from concrete VCs
+Re-target `ViewCtrlActor` bindings at protocols/view models instead of concrete VC types
+(coordinates with MODERNIZATION.md Phases 4–5). Unblocks DeviceScanner and Monitor shells.
+
+### PR 5+: Camera surface
+SwiftUI chrome around a `UIViewRepresentable` preview layer for `CameraViewController`;
+`WatchRemoteCameraController` follows.
+
+## Worklog (blog raw material)
+
+### PR 1 — dead code sweep
+- Inventory ran as two parallel read-only agents: one walked every view controller,
+  the other chased ObjC/bridging headers/deprecated APIs. ~30 min wall clock.
+- Expected storyboards to hunt; found none. The docs said "DeviceScannerViewController —
+  UIKit + Storyboard, entry point" — the code said otherwise. Docs lie, greps don't.
+- Best find: an entire permission system (`CameraAccess.swift`) still compiling,
+  fully replaced, zero callers — each method politely apologizing in comments that
+  the new system had taken over.
+- Dead-code cascade: deleting one orphaned IB controller made `UIButton.swift` dead,
+  which made `UIView.swift` dead. Delete one leaf, the branch comes with it.
+- Two "dead" files (`PopoverController.swift`, `TorchTest.swift`) turned out not to be
+  in the pbxproj at all — orphaned on disk, never even compiling.
+- Plot twist: removing `UIImage+ImageProcessing.h` from the bridging header broke the
+  build in 10 files that never imported UIKit. Its `#import <UIKit/UIKit.h>` had been
+  silently granting UIKit to every Swift file in the target for years. The dead code
+  was load-bearing — not for what it did, but for what it imported. Fix: explicit
+  `import UIKit` in the 10 files that were freeloading.
+- Net: 27 files changed, +136/−557 lines; 13 files deleted; 348/348 tests green.

RemoteCam/AlertPresenting.swift

@@ -6,6 +6,7 @@
 //
 
 import Foundation
+import UIKit
 
 /// Handle returned by `AlertPresenting.showAlert` for later update/dismiss.
 protocol AlertHandle: AnyObject {

RemoteCam/CGImage.swift

@@ -8,6 +8,7 @@
 
 import Foundation
 import AVFoundation
+import UIKit
 
 public class OrientationUtils {
 
@@ -27,54 +28,4 @@ public class OrientationUtils {
         }
     }
 
-    class public func transformToUIKit(o: AVCaptureVideoOrientation) -> UIInterfaceOrientation {
-        switch o {
-
-        case .landscapeLeft:
-            return .landscapeLeft
-
-        case .landscapeRight:
-            return .landscapeRight
-
-        case .portraitUpsideDown:
-            return .portraitUpsideDown
-
-        default:
-            return .portrait
-        }
-    }
-
-    class public func transformToUIImage(o: AVCaptureVideoOrientation) -> UIImage.Orientation {
-        switch o {
-
-        case .landscapeLeft:
-            return .left
-
-        case .landscapeRight:
-            return .right
-
-        case .portraitUpsideDown:
-            return .down
-
-        default:
-            return .up
-        }
-    }
-
-    class public func transformOrientationToImage(o: UIInterfaceOrientation) -> UIImage.Orientation {
-        switch o {
-
-        case .landscapeLeft:
-            return .left
-
-        case .landscapeRight:
-            return .right
-
-        case .portraitUpsideDown:
-            return .down
-
-        default:
-            return .up
-        }
-    }
 }

RemoteCam/CameraAccess.swift

@@ -7,6 +7,7 @@
 //
 
 import Foundation
+import UIKit
 
 func goToPhotos() {
     #if targetEnvironment(macCatalyst)

RemoteCam/OrientationUtils.swift

@@ -2,6 +2,5 @@
 //  Use this file to import your target's public headers that you would like to expose to Swift.
 //
 
-#import "UIImage+ImageProcessing.h"
 #import "RCTimer.h"
 #import "CPSoundManager.h"

RemoteCam/Photos.swift

@@ -8,6 +8,7 @@
 
 import Foundation
 import MultipeerConnectivity
+import UIKit
 
 extension RemoteCamSession {