Skip to content

Commit fa1eb0c

Browse files
committed
fix mypy errors
1 parent 430ec90 commit fa1eb0c

File tree

1 file changed

+16
-10
lines changed

1 file changed

+16
-10
lines changed

databunkerpro/api.py

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -252,20 +252,20 @@ def create_user(
252252
data: Dict[str, Any] = {"profile": profile}
253253
if options:
254254
# Handle groupname/groupid
255-
if "groupname" in options:
255+
if "groupname" in options and options["groupname"] is not None:
256256
if str(options["groupname"]).isdigit():
257257
data["groupid"] = int(options["groupname"])
258258
else:
259259
data["groupname"] = options["groupname"]
260-
elif "groupid" in options:
260+
elif "groupid" in options and options["groupid"] is not None:
261261
data["groupid"] = int(options["groupid"])
262262
# Handle rolename/roleid
263-
if "rolename" in options:
263+
if "rolename" in options and options["rolename"] is not None:
264264
if str(options["rolename"]).isdigit():
265265
data["roleid"] = int(options["rolename"])
266266
else:
267267
data["rolename"] = options["rolename"]
268-
elif "roleid" in options:
268+
elif "roleid" in options and options["roleid"] is not None:
269269
data["roleid"] = int(options["roleid"])
270270
# Handle time parameters
271271
if "slidingtime" in options:
@@ -314,29 +314,35 @@ def create_users_bulk(
314314
**(
315315
{"groupid": int(record["groupname"])}
316316
if "groupname" in record
317-
and str(record.get("groupname", "")).isdigit()
317+
and record["groupname"] is not None
318+
and str(record["groupname"]).isdigit()
318319
else (
319320
{"groupname": record["groupname"]}
320-
if "groupname" in record
321+
if "groupname" in record and record["groupname"] is not None
321322
else {}
322323
)
323324
),
324325
**(
325326
{"groupid": int(record["groupid"])}
326-
if "groupid" in record
327+
if "groupid" in record and record["groupid"] is not None
327328
else {}
328329
),
329330
**(
330331
{"roleid": int(record["rolename"])}
331332
if "rolename" in record
332-
and str(record.get("rolename", "")).isdigit()
333+
and record["rolename"] is not None
334+
and str(record["rolename"]).isdigit()
333335
else (
334336
{"rolename": record["rolename"]}
335-
if "rolename" in record
337+
if "rolename" in record and record["rolename"] is not None
336338
else {}
337339
)
338340
),
339-
**({"roleid": int(record["roleid"])} if "roleid" in record else {}),
341+
**(
342+
{"roleid": int(record["roleid"])}
343+
if "roleid" in record and record["roleid"] is not None
344+
else {}
345+
),
340346
}
341347
for record in records
342348
]

0 commit comments

Comments
 (0)