Skip to content
This repository was archived by the owner on Apr 11, 2024. It is now read-only.

Commit 7331fde

Browse files
fix(deps): Update html-sketchapp-cli to v2 (#29)
1 parent b3e61f5 commit 7331fde

File tree

3 files changed

+14
-18
lines changed

3 files changed

+14
-18
lines changed

package.json

+4-3
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
},
3636
"homepage": "https://github.com/seek-oss/html-sketchapp-cli#readme",
3737
"dependencies": {
38-
"@brainly/html-sketchapp": "^1.1.0",
38+
"@brainly/html-sketchapp": "^2.0.0",
3939
"es6-promisify": "^6.0.0",
4040
"find-up": "^2.1.0",
4141
"get-port": "^3.2.0",
@@ -58,9 +58,10 @@
5858
"husky": "^0.14.3",
5959
"jest": "^22.0.1",
6060
"rimraf": "^2.6.2",
61-
"semantic-release": "^12.4.1",
61+
"semantic-release": "^15.1.3",
6262
"traverse": "^0.6.6",
6363
"travis-deploy-once": "^4.3.4",
64-
"webpack": "^3.10.0"
64+
"webpack": "^4.1.1",
65+
"webpack-cli": "^2.0.12"
6566
}
6667
}

script/src/generateAlmostSketch.js

+9-15
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@ import Text from '@brainly/html-sketchapp/html2asketch/text.js';
44
import nodeToSketchLayers from '@brainly/html-sketchapp/html2asketch/nodeToSketchLayers.js';
55
import SymbolMaster from '@brainly/html-sketchapp/html2asketch/symbolMaster.js';
66

7-
const getAllLayers = async (item, symbolMastersByName = {}) => {
7+
const getAllLayers = (item, symbolMastersByName = {}) => {
88
const itemAndChildren = [item, ...item.querySelectorAll('*')];
99

1010
const symbolInstanceChildren = new Set([
1111
...item.querySelectorAll('[data-sketch-symbol-instance] *')
1212
]);
1313

14-
const layerPromises = Array.from(itemAndChildren).map(node => {
14+
const layers = Array.from(itemAndChildren).map(node => {
1515
if (node.dataset.sketchSymbolInstance) {
1616
const symbolName = node.dataset.sketchSymbolInstance;
1717

@@ -36,8 +36,6 @@ const getAllLayers = async (item, symbolMastersByName = {}) => {
3636
return nodeToSketchLayers(node);
3737
});
3838

39-
const layers = await Promise.all(layerPromises);
40-
4139
return layers.reduce((prev, current) => prev.concat(current), []);
4240
};
4341

@@ -52,12 +50,10 @@ export function snapshotColorStyles() {
5250
});
5351
}
5452

55-
export async function snapshotTextStyles({ suffix = '' }) {
56-
await Array.from(document.querySelectorAll('[data-sketch-text]'))
57-
.forEach(async item => {
58-
const layers = await getAllLayers(item);
59-
60-
layers
53+
export function snapshotTextStyles({ suffix = '' }) {
54+
Array.from(document.querySelectorAll('[data-sketch-text]'))
55+
.forEach(item => {
56+
getAllLayers(item)
6157
.filter(layer => layer instanceof Text)
6258
.forEach(layer => {
6359
const name = item.dataset.sketchText;
@@ -81,7 +77,7 @@ export function setupSymbols({ name }) {
8177
page.setName(name);
8278
}
8379

84-
export async function snapshotSymbols({ suffix = '' }) {
80+
export function snapshotSymbols({ suffix = '' }) {
8581
const nodes = Array.from(document.querySelectorAll('[data-sketch-symbol]'));
8682

8783
const symbolMastersByName = nodes.reduce((obj, item) => {
@@ -96,11 +92,11 @@ export async function snapshotSymbols({ suffix = '' }) {
9692
return obj;
9793
}, {});
9894

99-
const symbolPromises = nodes.map(async item => {
95+
const symbols = nodes.map(item => {
10096
const name = item.dataset.sketchSymbol;
10197
const symbol = symbolMastersByName[name];
10298

103-
const layers = await getAllLayers(item, symbolMastersByName);
99+
const layers = getAllLayers(item, symbolMastersByName);
104100

105101
layers
106102
.filter(layer => layer !== null)
@@ -109,8 +105,6 @@ export async function snapshotSymbols({ suffix = '' }) {
109105
return symbol;
110106
});
111107

112-
const symbols = await Promise.all(symbolPromises);
113-
114108
symbols.forEach(obj => page.addLayer(obj));
115109
}
116110

script/src/webpack.config.js

+1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
const path = require('path');
22

33
module.exports = {
4+
mode: 'production',
45
entry: path.resolve(__dirname, 'generateAlmostSketch.js'),
56
output: {
67
path: __dirname,

0 commit comments

Comments
 (0)