-
Notifications
You must be signed in to change notification settings - Fork 36
Open
Description
It has been raised that
skuba/template/lambda-sqs-worker-cdk/infra/appStack.test.ts
Lines 40 to 58 in 343795b
| const json = JSON.stringify(template.toJSON()) | |
| .replace( | |
| /"S3Key":"([0-9a-f]+)\.zip"/g, | |
| (_, hash) => `"S3Key":"${'x'.repeat(hash.length)}.zip"`, | |
| ) | |
| .replace( | |
| /workerCurrentVersion([0-9a-zA-Z]+)"/g, | |
| (_, hash) => `workerCurrentVersion${'x'.repeat(hash.length)}"`, | |
| ) | |
| .replaceAll( | |
| /"Value":"\d+\.\d+\.\d+-([^"]+)"/g, | |
| (_, hash) => `"Value": "x.x.x-${'x'.repeat(hash.length)}"`, | |
| ) | |
| .replaceAll(/"Value":"v\d+\.\d+\.\d+"/g, (_) => `"Value": "vx.x.x"`) | |
| .replace( | |
| /"DD_TAGS":"git.commit.sha:([0-9a-f]+),git.repository_url:([^\"]+)",/g, | |
| '', | |
| ) | |
| .replaceAll(/(layer:Datadog-[^-]+-.+?:)\d+/g, (_, layer) => `${layer}x`); |
is a bit of an eye sore.
Aaron suggested that we could hide some of the atrocities common issues in an internal package.
kdarvell
Metadata
Metadata
Assignees
Labels
No labels