Skip to content

Commit 5867bd2

Browse files
Copilotabhandage
andcommitted
Add 5 more destinations to centralized versioning-info.ts
Added: - amazon-amc (v2) - API profiles endpoint - nextdoor-capi (v2) - Conversions API - pushwoosh (v1) - Integration Segment API - yahoo-audiences (1.0) - OAuth version Co-authored-by: abhandage <174417010+abhandage@users.noreply.github.com>
1 parent 1f24273 commit 5867bd2

File tree

6 files changed

+32
-7
lines changed

6 files changed

+32
-7
lines changed

packages/destination-actions/src/destinations/amazon-amc/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import {
1414
REGEX_AUDIENCEID,
1515
TTL_MAX_VALUE
1616
} from './utils'
17+
import { AMAZON_AMC_API_VERSION } from '../versioning-info'
1718

1819
import syncAudiencesToDSP from './syncAudiencesToDSP'
1920

@@ -44,7 +45,7 @@ const destination: AudienceDestinationDefinition<Settings, AudienceSettings> = {
4445
}
4546

4647
try {
47-
await request<RefreshTokenResponse>(`${settings.region}/v2/profiles`, {
48+
await request<RefreshTokenResponse>(`${settings.region}/${AMAZON_AMC_API_VERSION}/profiles`, {
4849
method: 'GET',
4950
headers: {
5051
'Content-Type': 'application/json'

packages/destination-actions/src/destinations/nextdoor-capi/sendConversion/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import type { Payload } from './generated-types'
44
import { hashAndEncode } from './utils'
55
import { omit } from '@segment/actions-core'
66
import type { Custom, NDPayload, App } from './types'
7+
import { NEXTDOOR_CAPI_API_VERSION } from '../../versioning-info'
78

89
const action: ActionDefinition<Settings, Payload> = {
910
title: 'Send Conversion',
@@ -446,7 +447,7 @@ const action: ActionDefinition<Settings, Payload> = {
446447
partner_id: payload.partner_id
447448
}
448449

449-
return request('https://ads.nextdoor.com/v2/api/conversions/track', {
450+
return request(`https://ads.nextdoor.com/${NEXTDOOR_CAPI_API_VERSION}/api/conversions/track`, {
450451
method: 'post',
451452
headers: {
452453
'Content-Type': 'application/json',

packages/destination-actions/src/destinations/pushwoosh/index.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import { defaultValues } from '@segment/actions-core'
66

77
import trackEvent from './trackEvent'
88
import { getEndpoint } from './utilities'
9+
import { PUSHWOOSH_API_VERSION } from '../versioning-info'
910

1011
const destination: DestinationDefinition<Settings> = {
1112
name: 'Pushwoosh',
@@ -32,7 +33,7 @@ const destination: DestinationDefinition<Settings> = {
3233
},
3334

3435
testAuthentication: (request) => {
35-
const endpoint = getEndpoint('/integration-segment/v1/ping')
36+
const endpoint = getEndpoint(`/integration-segment/${PUSHWOOSH_API_VERSION}/ping`)
3637
return request(endpoint, {
3738
method: 'post',
3839
json: {
@@ -62,7 +63,7 @@ const destination: DestinationDefinition<Settings> = {
6263
],
6364

6465
onDelete: async (request, { payload }) => {
65-
const endpoint = getEndpoint('/integration-segment/v1/delete-user')
66+
const endpoint = getEndpoint(`/integration-segment/${PUSHWOOSH_API_VERSION}/delete-user`)
6667
return request(endpoint, {
6768
method: 'post',
6869
json: {

packages/destination-actions/src/destinations/pushwoosh/utilities.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { removeUndefined, RequestClient } from '@segment/actions-core'
22
import { Settings } from './generated-types'
33
import { Payload as TrackEventPayload } from './trackEvent/generated-types'
4+
import { PUSHWOOSH_API_VERSION } from '../versioning-info'
45

56
export function removeEmpty(obj: unknown) {
67
if (!obj) {
@@ -21,7 +22,7 @@ export function getEndpoint(url: string) {
2122
}
2223

2324
export function sendPostEvent(request: RequestClient, settings: Settings, payload: TrackEventPayload) {
24-
const endpoint = getEndpoint('/integration-segment/v1/post-events')
25+
const endpoint = getEndpoint(`/integration-segment/${PUSHWOOSH_API_VERSION}/post-events`)
2526
return request(endpoint, {
2627
method: 'post',
2728
json: {
@@ -53,7 +54,7 @@ export function sendBatchedPostEvent(request: RequestClient, settings: Settings,
5354
}
5455
})
5556

56-
const endpoint = getEndpoint('/integration-segment/v1/post-events')
57+
const endpoint = getEndpoint(`/integration-segment/${PUSHWOOSH_API_VERSION}/post-events`)
5758
return request(endpoint, {
5859
method: 'post',
5960
json: {

packages/destination-actions/src/destinations/versioning-info.ts

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -438,3 +438,23 @@ export const ROKT_API_VERSION = 'v3'
438438
* Insider Unification API version
439439
*/
440440
export const INSIDER_UNIFICATION_API_VERSION = 'v1'
441+
442+
/**
443+
* Amazon AMC/DSP API Version (for profiles endpoint)
444+
*/
445+
export const AMAZON_AMC_API_VERSION = 'v2'
446+
447+
/**
448+
* Nextdoor Conversions API Version
449+
*/
450+
export const NEXTDOOR_CAPI_API_VERSION = 'v2'
451+
452+
/**
453+
* Pushwoosh Integration Segment API Version
454+
*/
455+
export const PUSHWOOSH_API_VERSION = 'v1'
456+
457+
/**
458+
* Yahoo Audiences OAuth Version
459+
*/
460+
export const YAHOO_AUDIENCES_OAUTH_VERSION = '1.0'

packages/destination-actions/src/destinations/yahoo-audiences/utils-tax.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { createHmac } from 'crypto'
33
import { CredsObj, YahooSubTaxonomy } from './types'
44
import { RequestClient, IntegrationError } from '@segment/actions-core'
55
import { StatsClient } from '@segment/actions-core/destination-kit'
6+
import { YAHOO_AUDIENCES_OAUTH_VERSION } from '../versioning-info'
67

78
export function gen_customer_taxonomy_payload(settings: Settings) {
89
const data = {
@@ -63,7 +64,7 @@ export function gen_oauth1_signature(client_key: string, client_secret: string,
6364
.update(base_string)
6465
.digest('base64')
6566
)
66-
const oauth1_auth_string = `OAuth oauth_consumer_key="${client_key}", oauth_nonce="${nonce}", oauth_signature="${signature}", oauth_signature_method="HMAC-SHA1", oauth_timestamp="${timestamp}", oauth_version="1.0"`
67+
const oauth1_auth_string = `OAuth oauth_consumer_key="${client_key}", oauth_nonce="${nonce}", oauth_signature="${signature}", oauth_signature_method="HMAC-SHA1", oauth_timestamp="${timestamp}", oauth_version="${YAHOO_AUDIENCES_OAUTH_VERSION}"`
6768
return oauth1_auth_string
6869
}
6970

0 commit comments

Comments
 (0)