Skip to content

Commit c0832df

Browse files
Copilotabhandage
andcommitted
Add 2 more destinations to centralized versioning-info.ts
Added: - airship (version 3) - Urban Airship API version - tiktok-offline-conversions (v1.3) - Offline event tracking API Updated files: - airship/index.ts - Import and use AIRSHIP_API_VERSION - tiktok-offline-conversions/index.ts - Import and export API_VERSION - tiktok-offline-conversions/utils.ts - Use TIKTOK_OFFLINE_CONVERSIONS_API_VERSION in API URLs Co-authored-by: abhandage <174417010+abhandage@users.noreply.github.com>
1 parent f63fd5a commit c0832df

File tree

4 files changed

+20
-3
lines changed

4 files changed

+20
-3
lines changed

packages/destination-actions/src/destinations/airship/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { DestinationDefinition, defaultValues } from '@segment/actions-core'
22
import type { Settings } from './generated-types'
3+
import { AIRSHIP_API_VERSION } from '../versioning-info'
34

45
import customEvents from './customEvents'
56

@@ -91,7 +92,7 @@ const destination: DestinationDefinition<Settings> = {
9192
headers: {
9293
Authorization: `Bearer ${settings.access_token}`,
9394
'X-UA-Appkey': `${settings.app_key}`,
94-
Accept: 'application/vnd.urbanairship+json; version=3',
95+
Accept: `application/vnd.urbanairship+json; version=${AIRSHIP_API_VERSION}`,
9596
'Content-Type': 'application/json'
9697
}
9798
}

packages/destination-actions/src/destinations/tiktok-offline-conversions/index.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
11
import { defaultValues, DestinationDefinition } from '@segment/actions-core'
22
import type { Settings } from './generated-types'
3+
import { TIKTOK_OFFLINE_CONVERSIONS_API_VERSION } from '../versioning-info'
34
import trackPaymentOfflineConversion from './trackPaymentOfflineConversion'
45
import trackNonPaymentOfflineConversion from './trackNonPaymentOfflineConversion'
56
import reportOfflineEvent from './reportOfflineEvent'
67

8+
export { TIKTOK_OFFLINE_CONVERSIONS_API_VERSION as API_VERSION }
9+
710
const productProperties = {
811
price: {
912
'@path': '$.price'
@@ -73,7 +76,7 @@ const destination: DestinationDefinition<Settings> = {
7376
}
7477
},
7578
testAuthentication: (request, { settings }) => {
76-
return request('https://business-api.tiktok.com/open_api/v1.3/offline/track/', {
79+
return request(`https://business-api.tiktok.com/open_api/${TIKTOK_OFFLINE_CONVERSIONS_API_VERSION}/offline/track/`, {
7780
method: 'post',
7881
json: {
7982
event_set_id: settings.eventSetID,

packages/destination-actions/src/destinations/tiktok-offline-conversions/utils.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { RequestClient, PayloadValidationError } from '@segment/actions-core'
22
import { Settings } from './generated-types'
3+
import { TIKTOK_OFFLINE_CONVERSIONS_API_VERSION } from '../versioning-info'
34
import { Payload as ReportOfflineEventPayload } from './reportOfflineEvent/generated-types'
45
import { Payload as TrackNonPaymentOfflineConversionPayload } from './trackNonPaymentOfflineConversion/generated-types'
56
import { Payload as TrackPaymentOfflineConversionPayload } from './trackPaymentOfflineConversion/generated-types'
@@ -31,7 +32,7 @@ export function performOfflineEvent(request: RequestClient, settings: Settings,
3132

3233
if (payloadUrl) urlTtclid = payloadUrl.searchParams.get('ttclid')
3334

34-
return request('https://business-api.tiktok.com/open_api/v1.3/event/track/', {
35+
return request(`https://business-api.tiktok.com/open_api/${TIKTOK_OFFLINE_CONVERSIONS_API_VERSION}/event/track/`, {
3536
method: 'post',
3637
json: {
3738
event_source: 'offline',

packages/destination-actions/src/destinations/versioning-info.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -568,3 +568,15 @@ export const MANTLE_API_VERSION = 'v1'
568568
* TikTok App Events API Version
569569
*/
570570
export const TIKTOK_APP_EVENTS_API_VERSION = 'v1.3'
571+
572+
/**
573+
* Airship API Version
574+
* Used in the Accept header for Urban Airship API requests
575+
*/
576+
export const AIRSHIP_API_VERSION = '3'
577+
578+
/**
579+
* TikTok Offline Conversions API Version
580+
* Used for offline event tracking endpoints
581+
*/
582+
export const TIKTOK_OFFLINE_CONVERSIONS_API_VERSION = 'v1.3'

0 commit comments

Comments
 (0)