Skip to content

Commit c7ca29f

Browse files
Copilotabhandage
andcommitted
Add 6 more destinations to centralized versioning-info.ts
Added: - close (v1) - dawn (v1) - drip (v2) - identify, trackEvent, index - engage-messaging-sendgrid (v3) - engage-messaging-twilio (v1) Co-authored-by: abhandage <174417010+abhandage@users.noreply.github.com>
1 parent fa17bef commit c7ca29f

File tree

9 files changed

+43
-9
lines changed

9 files changed

+43
-9
lines changed

packages/destination-actions/src/destinations/close/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ const destination: DestinationDefinition<Settings> = {
4949
}
5050
},
5151
testAuthentication: (request) => {
52-
return request(`https://api.close.com/api/v1/me/?_fields=id`)
52+
return request(`${CLOSE_BASE_URL}/me/?_fields=id`)
5353
}
5454
},
5555

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,3 @@
1-
export const DAWN_API_ENDPOINT = 'https://api2.dawnai.com/v1'
1+
import { DAWN_API_VERSION } from '../versioning-info'
2+
3+
export const DAWN_API_ENDPOINT = `https://api2.dawnai.com/${DAWN_API_VERSION}`

packages/destination-actions/src/destinations/drip/identify/index.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import type { ActionDefinition } from '@segment/actions-core'
22
import type { Settings } from '../generated-types'
33
import type { Payload } from './generated-types'
4+
import { DRIP_API_VERSION } from '../../versioning-info'
45

56
const person = (payload: Payload) => {
67
return {
@@ -113,15 +114,15 @@ const action: ActionDefinition<Settings, Payload> = {
113114
}
114115
},
115116
perform: (request, { settings, payload }) => {
116-
return request(`https://api.getdrip.com/v2/${settings.accountId}/subscribers`, {
117+
return request(`https://api.getdrip.com/${DRIP_API_VERSION}/${settings.accountId}/subscribers`, {
117118
method: 'POST',
118119
json: { subscribers: [person(payload)] }
119120
})
120121
},
121122
performBatch: (request, { settings, payload }) => {
122123
const subscribers = payload.map(person)
123124

124-
return request(`https://api.getdrip.com/v2/${settings.accountId}/subscribers/batches`, {
125+
return request(`https://api.getdrip.com/${DRIP_API_VERSION}/${settings.accountId}/subscribers/batches`, {
125126
method: 'POST',
126127
json: { batches: [{ subscribers }] }
127128
})

packages/destination-actions/src/destinations/drip/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ const destination: DestinationDefinition<Settings> = {
2525
}
2626
},
2727
testAuthentication: (request) => {
28-
return request(`https://api.getdrip.com/v2/user`, {
28+
return request(`https://api.getdrip.com/${DRIP_API_VERSION}/user`, {
2929
method: 'get'
3030
})
3131
}

packages/destination-actions/src/destinations/drip/trackEvent/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import type { ActionDefinition } from '@segment/actions-core'
22
import type { Settings } from '../generated-types'
33
import type { Payload } from './generated-types'
4+
import { DRIP_API_VERSION } from '../../versioning-info'
45

56
const action: ActionDefinition<Settings, Payload> = {
67
title: 'Track Event',
@@ -38,7 +39,7 @@ const action: ActionDefinition<Settings, Payload> = {
3839
},
3940

4041
perform: (request, { settings, payload }) => {
41-
return request(`https://api.getdrip.com/v2/${settings.accountId}/events`, {
42+
return request(`https://api.getdrip.com/${DRIP_API_VERSION}/${settings.accountId}/events`, {
4243
method: 'POST',
4344
json: {
4445
events: [

packages/destination-actions/src/destinations/engage-messaging-sendgrid/sendEmail/SendEmailPerformer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ export class SendEmailPerformer extends MessageSendPerformer<Settings, Payload>
260260
json: mailContent
261261
}
262262
//this.statsClient?.set('message_body_size', JSON.stringify(req).length) // Commented due to performance issues
263-
const response = await this.request('https://api.sendgrid.com/v3/mail/send', req)
263+
const response = await this.request(`https://api.sendgrid.com/${ENGAGE_MESSAGING_SENDGRID_API_VERSION}/mail/send`, req)
264264
if (this.payload?.eventOccurredTS != undefined) {
265265
this.statsClient?.histogram(
266266
'eventDeliveryTS',

packages/destination-actions/src/destinations/engage-messaging-twilio/sendMobilePush/PushSender.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ export class PushSender extends TwilioMessageSender<PushPayload> {
8585
this.statsSet('message_body_size', body?.toString().length)
8686
body.sort()
8787

88-
const res = await this.request(`https://${this.twilioHostname}/v1/Services/${this.payload.from}/Notifications`, {
88+
const res = await this.request(`https://${this.twilioHostname}/${ENGAGE_MESSAGING_TWILIO_API_VERSION}/Services/${this.payload.from}/Notifications`, {
8989
method: 'POST',
9090
headers: {
9191
authorization: `Basic ${this.twilioToken}`

packages/destination-actions/src/destinations/engage-messaging-twilio/utils/TwilioMessageSender.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ export abstract class TwilioMessageSender<TPayload extends TwilioPayloadBase> ex
7272
const twilioToken = Buffer.from(`${this.settings.twilioApiKeySID}:${this.settings.twilioApiKeySecret}`).toString(
7373
'base64'
7474
)
75-
const response = await this.request(`https://content.twilio.com/v1/Content/${this.payload.contentSid}`, {
75+
const response = await this.request(`https://content.twilio.com/${ENGAGE_MESSAGING_TWILIO_API_VERSION}/Content/${this.payload.contentSid}`, {
7676
method: 'GET',
7777
headers: {
7878
authorization: `Basic ${twilioToken}`

packages/destination-actions/src/destinations/versioning-info.ts

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -288,3 +288,33 @@ export const ATTIO_API_VERSION = 'v1'
288288
* 1plusX API Version
289289
*/
290290
export const ONEPLUSX_API_VERSION = 'v2'
291+
292+
/**
293+
* Close API Version
294+
*/
295+
export const CLOSE_API_VERSION = 'v1'
296+
297+
/**
298+
* Dawn API Version
299+
*/
300+
export const DAWN_API_VERSION = 'v1'
301+
302+
/**
303+
* Dotdigital API Version
304+
*/
305+
export const DOTDIGITAL_API_VERSION = 'v2'
306+
307+
/**
308+
* Drip API Version
309+
*/
310+
export const DRIP_API_VERSION = 'v2'
311+
312+
/**
313+
* Engage Messaging SendGrid API Version
314+
*/
315+
export const ENGAGE_MESSAGING_SENDGRID_API_VERSION = 'v3'
316+
317+
/**
318+
* Engage Messaging Twilio API Version
319+
*/
320+
export const ENGAGE_MESSAGING_TWILIO_API_VERSION = 'v1'

0 commit comments

Comments
 (0)