fix: add sasl-secrets-manager-arn to shared opts (#225)

petedannemann · web-flow · commit 783435ae9522 · 2025-03-06T11:53:35.000-05:00
* fix: add sasl-secrets-manager-arn to shared opts

* persistentflags -&gt; flags
diff --git a/cmd/topicctl/subcmd/shared.go b/cmd/topicctl/subcmd/shared.go
@@ -314,4 +314,10 @@ func addSharedConfigOnlyFlags(cmd *cobra.Command, options *sharedOptions) {
 		os.Getenv("TOPICCTL_SASL_USERNAME"),
 		"SASL username if using SASL; will override value set in cluster config",
 	)
+	cmd.Flags().StringVar(
+		&options.saslSecretsManagerArn,
+		"sasl-secrets-manager-arn",
+		os.Getenv("TOPICCTL_SASL_SECRETS_MANAGER_ARN"),
+		"Secrets Manager ARN to use for credentials if using SASL; will override value set in cluster config",
+	)
 }

Original file line number	Diff line number	Diff line change
`@@ -314,4 +314,10 @@ func addSharedConfigOnlyFlags(cmd cobra.Command, options sharedOptions) {`
`314`	`314`	`os.Getenv("TOPICCTL_SASL_USERNAME"),`
`315`	`315`	`"SASL username if using SASL; will override value set in cluster config",`
`316`	`316`	`)`
	`317`	`+ cmd.Flags().StringVar(`
	`318`	`+ &options.saslSecretsManagerArn,`
	`319`	`+ "sasl-secrets-manager-arn",`
	`320`	`+ os.Getenv("TOPICCTL_SASL_SECRETS_MANAGER_ARN"),`
	`321`	`+ "Secrets Manager ARN to use for credentials if using SASL; will override value set in cluster config",`
	`322`	`+ )`
`317`	`323`	`}`