Add order validation (#173)

Author: codchen

x/dex/keeper/msgserver/msg_server_place_orders.go

@@ -2,6 +2,7 @@ package msgserver
 
 import (
 	"context"
+	"errors"
 	"math/big"
 
 	conversion "github.com/sei-protocol/sei-chain/utils"
@@ -17,8 +18,6 @@ func (k msgServer) transferFunds(goCtx context.Context, msg *types.MsgPlaceOrder
 	if len(msg.Funds) == 0 {
 		return nil
 	}
-	_, span := (*k.tracingInfo.Tracer).Start(goCtx, "TransferFunds")
-	defer span.End()
 
 	ctx := sdk.UnwrapSDKContext(goCtx)
 	contractAddr, err := sdk.AccAddressFromBech32(msg.ContractAddr)
@@ -43,11 +42,14 @@ func (k msgServer) transferFunds(goCtx context.Context, msg *types.MsgPlaceOrder
 }
 
 func (k msgServer) PlaceOrders(goCtx context.Context, msg *types.MsgPlaceOrders) (*types.MsgPlaceOrdersResponse, error) {
-	spanCtx, span := (*k.tracingInfo.Tracer).Start(goCtx, "PlaceOrders")
-	defer span.End()
-
 	ctx := sdk.UnwrapSDKContext(goCtx)
 
+	for _, order := range msg.Orders {
+		if err := k.validateOrder(order); err != nil {
+			return nil, err
+		}
+	}
+
 	if msg.AutoCalculateDeposit {
 		calculatedCollateral := sdk.NewDecFromBigInt(big.NewInt(0))
 		for _, order := range msg.Orders {
@@ -69,7 +71,7 @@ func (k msgServer) PlaceOrders(goCtx context.Context, msg *types.MsgPlaceOrders)
 		msg.Funds[0].Denom = newDenom
 	}
 
-	if err := k.transferFunds(spanCtx, msg); err != nil {
+	if err := k.transferFunds(goCtx, msg); err != nil {
 		return nil, err
 	}
 
@@ -95,3 +97,13 @@ func (k msgServer) PlaceOrders(goCtx context.Context, msg *types.MsgPlaceOrders)
 		OrderIds: idsInResp,
 	}, nil
 }
+
+func (k msgServer) validateOrder(order *types.Order) error {
+	if order.Quantity.IsNil() {
+		return errors.New("quantity cannot be empty")
+	}
+	if order.Price.IsNil() {
+		return errors.New("price cannot be empty")
+	}
+	return nil
+}

x/dex/keeper/msgserver/msg_server_place_orders_test.go

@@ -0,0 +1,96 @@
+package msgserver_test
+
+import (
+	"testing"
+
+	sdk "github.com/cosmos/cosmos-sdk/types"
+	keepertest "github.com/sei-protocol/sei-chain/testutil/keeper"
+	"github.com/sei-protocol/sei-chain/x/dex/keeper/msgserver"
+	"github.com/sei-protocol/sei-chain/x/dex/types"
+	"github.com/stretchr/testify/require"
+)
+
+const TestCreator = "sei1ewxvf5a9wq9zk5nurtl6m9yfxpnhyp7s7uk5sl"
+const TestContract = "sei14hj2tavq8fpesdwxxcu44rty3hh90vhujrvcmstl4zr3txmfvw9sh9m79m"
+
+func TestPlaceOrder(t *testing.T) {
+	msg := &types.MsgPlaceOrders{
+		Creator:      TestCreator,
+		ContractAddr: TestContract,
+		Orders: []*types.Order{
+			{
+				Price:             sdk.MustNewDecFromStr("10"),
+				Quantity:          sdk.MustNewDecFromStr("10"),
+				Data:              "",
+				PositionDirection: types.PositionDirection_LONG,
+				OrderType:         types.OrderType_LIMIT,
+				PriceDenom:        keepertest.TestPriceDenom,
+				AssetDenom:        keepertest.TestAssetDenom,
+			},
+			{
+				Price:             sdk.MustNewDecFromStr("20"),
+				Quantity:          sdk.MustNewDecFromStr("5"),
+				Data:              "",
+				PositionDirection: types.PositionDirection_SHORT,
+				OrderType:         types.OrderType_MARKET,
+				PriceDenom:        keepertest.TestPriceDenom,
+				AssetDenom:        keepertest.TestAssetDenom,
+			},
+		},
+	}
+	keeper, ctx := keepertest.DexKeeper(t)
+	keeper.AddRegisteredPair(ctx, TestContract, keepertest.TestPair)
+	keeper.SetTickSizeForPair(ctx, TestContract, keepertest.TestPair, *keepertest.TestPair.Ticksize)
+	wctx := sdk.WrapSDKContext(ctx)
+	server := msgserver.NewMsgServerImpl(*keeper, nil)
+	res, err := server.PlaceOrders(wctx, msg)
+	require.Nil(t, err)
+	require.Equal(t, 2, len(res.OrderIds))
+	require.Equal(t, uint64(0), res.OrderIds[0])
+	require.Equal(t, uint64(1), res.OrderIds[1])
+}
+
+func TestPlaceInvalidOrder(t *testing.T) {
+	keeper, ctx := keepertest.DexKeeper(t)
+	keeper.AddRegisteredPair(ctx, TestContract, keepertest.TestPair)
+	keeper.SetTickSizeForPair(ctx, TestContract, keepertest.TestPair, *keepertest.TestPair.Ticksize)
+	wctx := sdk.WrapSDKContext(ctx)
+
+	msg := &types.MsgPlaceOrders{
+		Creator:      TestCreator,
+		ContractAddr: TestContract,
+		Orders: []*types.Order{
+			{
+				Price:             sdk.MustNewDecFromStr("10"),
+				Quantity:          sdk.Dec{},
+				Data:              "",
+				PositionDirection: types.PositionDirection_LONG,
+				OrderType:         types.OrderType_LIMIT,
+				PriceDenom:        keepertest.TestPriceDenom,
+				AssetDenom:        keepertest.TestAssetDenom,
+			},
+		},
+	}
+	server := msgserver.NewMsgServerImpl(*keeper, nil)
+	_, err := server.PlaceOrders(wctx, msg)
+	require.NotNil(t, err)
+
+	msg = &types.MsgPlaceOrders{
+		Creator:      TestCreator,
+		ContractAddr: TestContract,
+		Orders: []*types.Order{
+			{
+				Price:             sdk.Dec{},
+				Quantity:          sdk.MustNewDecFromStr("10"),
+				Data:              "",
+				PositionDirection: types.PositionDirection_LONG,
+				OrderType:         types.OrderType_LIMIT,
+				PriceDenom:        keepertest.TestPriceDenom,
+				AssetDenom:        keepertest.TestAssetDenom,
+			},
+		},
+	}
+	server = msgserver.NewMsgServerImpl(*keeper, nil)
+	_, err = server.PlaceOrders(wctx, msg)
+	require.NotNil(t, err)
+}