Make CakeValidationValidationConverter non static

Author: odan

src/Converter/CakeValidationValidationConverter.php renamed to src/Converter/CakeValidationConverter.php

@@ -7,7 +7,7 @@
 /**
  * CakePHP validation error convert.
  */
-final class CakeValidationValidationConverter implements ValidationConverterInterface
+final class CakeValidationConverter implements ValidationConverterInterface
 {
     /**
      * Create validation result from array with errors.

src/Converter/ValitronValidationValidationConverter.php

@@ -0,0 +1,37 @@
+<?php
+
+namespace Selective\Validation\Converter;
+
+use Selective\Validation\ValidationResult;
+
+/**
+ * Valitron validation error collector.
+ */
+final class ValitronValidationValidationConverter implements ValidationConverterInterface
+{
+    /**
+     * Create validation result from array with errors.
+     *
+     * @param array $errors The errors
+     *
+     * @return ValidationResult The result
+     */
+    public function createValidationResult($errors): ValidationResult
+    {
+        $result = new ValidationResult();
+
+        $fields = [];
+
+        foreach ($errors as $field => $message) {
+            if (isset($fields[$field])) {
+                continue;
+            }
+
+            $result->addError($field, $message);
+
+            $fields[$field] = 1;
+        }
+
+        return $result;
+    }
+}

src/Factory/CakeValidationFactory.php

@@ -3,7 +3,7 @@
 namespace Selective\Validation\Factory;
 
 use Cake\Validation\Validator;
-use Selective\Validation\Converter\CakeValidationValidationConverter;
+use Selective\Validation\Converter\CakeValidationConverter;
 use Selective\Validation\ValidationResult;
 
 /**
@@ -30,6 +30,6 @@ public function createValidator(): Validator
      */
     public function createValidationResult(array $errors): ValidationResult
     {
-        return (new CakeValidationValidationConverter())->createValidationResult($errors);
+        return (new CakeValidationConverter())->createValidationResult($errors);
     }
 }

tests/Converter/CakeValidationFactoryTest.php

@@ -3,7 +3,7 @@
 namespace Selective\Validation\Test\Converter;
 
 use PHPUnit\Framework\TestCase;
-use Selective\Validation\Converter\CakeValidationValidationConverter;
+use Selective\Validation\Converter\CakeValidationConverter;
 use Selective\Validation\Transformer\ErrorDetailsResultTransformer;
 use Selective\Validation\ValidationResult;
 
@@ -31,7 +31,7 @@ private function getValidationResultAsArray(ValidationResult $validationResult):
      */
     public function testCreateResultFromErrorsSimple()
     {
-        $result = (new CakeValidationValidationConverter())->createValidationResult([
+        $result = (new CakeValidationConverter())->createValidationResult([
             'first_name' => [
                 '_empty' => 'This field cannot be left empty',
             ],
@@ -104,7 +104,7 @@ public function testCreateResultFromErrorsSimple()
      */
     public function testCreateResultFromErrorsNestedArray()
     {
-        $result = (new CakeValidationValidationConverter())->createValidationResult([
+        $result = (new CakeValidationConverter())->createValidationResult([
             'bills' => [
                 0 => [
                     'billing_number' => [