In getGroupMembers, the code assumes memberAddedEvents[i] contains the event for member at index i. However, memberAddedEvents is ordered by event occurrence, not by member index.
|
members.push(memberAddedEvents[i][2]) |
This fails when members are added via both addMembers (batch) and addMember (single).
Example:
- Batch add at indices 0-1
- Single add at index 2
memberAddedEvents has 1 element, but the code tries to access memberAddedEvents[2] → undefined.
Fix: Use a map keyed by member index instead of array position.
In
getGroupMembers, the code assumesmemberAddedEvents[i]contains the event for member at indexi. However,memberAddedEventsis ordered by event occurrence, not by member index.semaphore/packages/data/src/ethers.ts
Line 236 in 1663372
This fails when members are added via both
addMembers(batch) andaddMember(single).Example:
memberAddedEventshas 1 element, but the code tries to accessmemberAddedEvents[2]→ undefined.Fix: Use a map keyed by member index instead of array position.