Skip to content

Commit

Permalink
Remove internal bazel build and Circle CI (#1145)
Browse files Browse the repository at this point in the history
Now that we've migrated to a new tooling stack based on uv/GitHub
Actions, we can drop bazel and CircleCI. This PR removes those things
that are inessential.

With regards to bazel, it is important to note that there are two
factors to consider:
(1) Support for bazel to manage development and maintenance of Sematic
itself
(2) Making it possible and convenient for Sematic to run pipelines for
python code & images produced with bazel

This PR drops (1) but *not* (2). However, the bazel support for examples
was also dropped. The intent being to refer to
https://github.com/sematic-ai/example_bazel as an example of how one can
create a pipeline using Sematic + bazel.

With regards to bazel integration for (1), there are a number of
accommodations made in the code for this, the most complex being support
for producing images capable of being used as Ray head and worker nodes
along with the pipeline. To ensure that these changes did not break
that, I modified our `example_bazel` repo to use a small Ray cluster and
ran it against the version of our bazel workspace from this branch. The
branch used for this testing is
[here](https://github.com/sematic-ai/example_bazel/tree/augray/ray-test)
I confirmed that the pipeline ran, spun up an ephemeral Ray cluster, and
used it before exiting.

---------

Co-authored-by: Chance An <[email protected]>
Co-authored-by: Josh <[email protected]>
  • Loading branch information
3 people authored Jan 8, 2025
1 parent 554cdfb commit 5311664
Show file tree
Hide file tree
Showing 123 changed files with 22 additions and 18,918 deletions.
1 change: 0 additions & 1 deletion .bazelignore

This file was deleted.

4 changes: 0 additions & 4 deletions .bazelrc

This file was deleted.

163 changes: 0 additions & 163 deletions .circleci/config.yml

This file was deleted.

27 changes: 0 additions & 27 deletions .circleci/retry

This file was deleted.

76 changes: 0 additions & 76 deletions BUILD

This file was deleted.

28 changes: 2 additions & 26 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ migrate_down_sqlite:
clear_sqlite:
sqlite3 ~/.sematic/db.sqlite3 < sematic/db/scripts/clear_all.sql

install-dev-deps:
pip3 install -r requirements/ci-requirements.txt

pre-commit:
uvx ruff format --check
uvx ruff check --fix sematic
Expand Down Expand Up @@ -63,22 +60,6 @@ worker-image:
sematic/ui/build:
@$(MAKE) ui

wheel : sematic/ui/build
rm -f bazel-bin/sematic/*.whl
rm -f bazel-bin/sematic/ee/*.whl
cat README.md | \
grep -v "<img" | \
grep -v "<p" | \
grep -v "/p>" | \
grep -v "<h2" | \
grep -v "/h2>" | \
grep -v "<h3" | \
grep -v "/h3>" | \
grep -v "<a" | \
grep -v "/a>" | \
grep -v "/img>" > README.nohtml
bazel build //sematic:wheel

uv-wheel:
cat README.md | \
grep -v "<img" | \
Expand All @@ -91,10 +72,8 @@ uv-wheel:
grep -v "<a" | \
grep -v "/a>" | \
grep -v "/img>" > README.nohtml
# source .venv/bin/activate && python3 -m pandoc read --format=markdown README.nohtml
cp BUILD tmp.BUILD
rm -rf dist build src/*.egg-info
uvx pip wheel -w dist . && rm -rf build && mv tmp.BUILD BUILD
uvx pip wheel -w dist . && rm -rf build
rm README.nohtml

test-release:
Expand All @@ -113,7 +92,4 @@ release-server:
docker push sematic/sematic-server-ee:${TAG}

test:
bazel test //sematic/... --test_tag_filters=nocov --test_output=all

coverage:
bazel coverage //sematic/... --combined_report=lcov --test_tag_filters=cov --test_output=all
source .venv/bin/activate && pytest
Loading

0 comments on commit 5311664

Please sign in to comment.