Skip to content

Commit 0f07814

Browse files
committed
simplifya
1 parent f5beed6 commit 0f07814

7 files changed

+27
-306
lines changed

semgrep_output_v1.atd

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1617,32 +1617,15 @@ type parsing_stats = {
16171617
num_bytes: int;
16181618
}
16191619

1620-
(*
1621-
Policy/automation related data the app wants the CLI to know about
1622-
certain findings. Right now this is only used for the app to cause
1623-
a CI scan to block, so 'kind' can only ever be "block". The list
1624-
of match_based_ids are the MIDs of the findings that the action
1625-
relates to. If a "block" action is present, the `app_block_override`
1626-
field should be true.
1627-
1628-
This a record with a 'kind' field instead
1629-
instead of a sum type because ATD doesn't have convenient support for
1630-
adding new constructors to sum types without breaking backwards compatibility.
1631-
Right now we only have one kind of action ("block"), but in the future we may add more.
1632-
e.g. we could inform the CLI that a certain list of findings triggered a PR comment
1633-
*)
1634-
type app_finding_action = {
1635-
kind : string;
1636-
match_based_ids : string list;
1637-
}
16381620

16391621
(* Response by the backend to the CLI to the POST /complete *)
16401622
type ci_scan_complete_response <ocaml attr="deriving show"> = {
16411623
success: bool;
16421624
~app_block_override: bool;
16431625
(* only when app_block_override is true *)
16441626
~app_block_reason: string;
1645-
~app_finding_actions : app_finding_action list;
1627+
(* match_based_ids of findings that semgrep-app determined should cause the scan to block *)
1628+
~app_blocking_match_based_ids : string list;
16461629
}
16471630

16481631
(* ----------------------------- *)

semgrep_output_v1.jsonschema

Lines changed: 2 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

semgrep_output_v1.proto

Lines changed: 2 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

semgrep_output_v1.py

Lines changed: 3 additions & 34 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

semgrep_output_v1.ts

Lines changed: 3 additions & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)