Skip to content

Commit

Permalink
chore(lfs): Added manifest_path to FoundDependency (#311)
Browse files Browse the repository at this point in the history
In order to better support PTT, the CLI will now be able to record a
dependency's manifest filepath using the new attribute added in this PR.

- [x] I ran `make setup && make` to update the generated code after
editing a `.atd` file (TODO: have a CI check)
- [x] I made sure we're still backward compatible with old versions of
the CLI.
For example, the Semgrep backend need to still be able to *consume* data
generated
	  by Semgrep 1.17.0.
See
https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades
  • Loading branch information
SayyantR authored Nov 7, 2024
1 parent 1446208 commit 64dd682
Show file tree
Hide file tree
Showing 7 changed files with 102 additions and 25 deletions.
5 changes: 5 additions & 0 deletions semgrep_output_v1.atd
Original file line number Diff line number Diff line change
Expand Up @@ -1113,6 +1113,11 @@ type found_dependency = {
<ts repr="map">;
?resolved_url: string option;
transitivity: transitivity;
(* Path to the manifest file that defines the project containing this dependency
*
* Examples: package.json, nested/folder/pom.xml
*)
?manifest_path: fpath option;
(* Path to the lockfile that contains this dependency.
*
* Examples: package-lock.json, nested/folder/requirements.txt, go.mod
Expand Down
1 change: 1 addition & 0 deletions semgrep_output_v1.jsonschema

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion semgrep_output_v1.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions semgrep_output_v1.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions semgrep_output_v1.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

110 changes: 86 additions & 24 deletions semgrep_output_v1_j.ml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions semgrep_output_v1_j.mli

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 64dd682

Please sign in to comment.