Why overwritten async validations always succeeds

[sabob]

Hi all,

I know the project is dormant currently but perhaps someone might know why async validations that is "overwritten" by a second async call succeeds eg.

let success = await $validate() will return true if an async validation is triggered again before the original event completes.

If my explanation is a bit confusing the lines in question is here:

simple-vue-validator/src/validation-bag.js

Lines 238 to 242 in 0ee438e

	if (this.isValidating(field, validatingId)) {
	//console.log(validatingId + ' | ' + 'processed');
	return addMessages(messages);
	}
	return false;

specifically line 242 returns false, meaning there is no error. Isn't it safer to return true rather?

Kind regards

Bob

[semisleep]

Hi there, if async $validate() is invoked again before the previous one completes, there's no way to guarantee that the result of the previous async $validate() is correct. This is because all $validate() invocations share the same ValidationBag, which can only hold the result of the latest $validate() state.

[sabob]

Thanks for your response. Sounds we are saying the same thing and perhaps I misread the code but I think line 242 really says:

var hasError = false;
return hasError;

meaning $validate succeeds for the first call. Shouldn't it be:

var hasError = true;
return hasError;

so that the first request always fails and the second request will return an accurate response?