Improve crc32-based getValueHash method to work better on 32 and 64 bit machines.

bnowack · bnowack · commit 8a35ff12a6d4 · 2013-12-12T16:02:21.000+01:00
diff --git a/store/ARC2_Store.php b/store/ARC2_Store.php
@@ -497,11 +497,11 @@ function processTriggers($type, $infos) {
   /*  */
 
   function getValueHash($val, $_32bit = false) {
-    $hash = abs(crc32($val));
+    $hash = crc32($val);
 	if ($_32bit && ($hash & 0x80000000)) {
-	  $hash ^= 0xffffffff;
-	  $hash += 1;
+        $hash = sprintf("%u", $hash);
 	}
+    $hash = abs($hash);
 	return $hash;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -497,11 +497,11 @@ function processTriggers($type, $infos) {`
`497`	`497`	`/* */`
`498`	`498`
`499`	`499`	`function getValueHash($val, $_32bit = false) {`
`500`		`- $hash = abs(crc32($val));`
	`500`	`+ $hash = crc32($val);`
`501`	`501`	`if ($_32bit && ($hash & 0x80000000)) {`
`502`		`- $hash ^= 0xffffffff;`
`503`		`- $hash += 1;`
	`502`	`+ $hash = sprintf("%u", $hash);`
`504`	`503`	`}`
	`504`	`+ $hash = abs($hash);`
`505`	`505`	`return $hash;`
`506`	`506`	`}`
`507`	`507`