Merge pull request #127 from sendbird/v4.2.27

Add 4.2.27.

Author: sf-tyler-jeong

CHANGELOG.md

@@ -1,3 +1,12 @@
+## v4.2.27 (Nov 6, 2024)
+
+### Features
+- Applied the message threading policy for last message and unread message count in `GroupChannel`
+
+### Improvements
+- Fixed a bug where update events are not called for messages with OGTags
+- Fixed the reconnection events to be called in pairs
+
 ## v4.2.26 (Oct 28, 2024)
 
 ### Features

README.md

@@ -50,7 +50,7 @@ Before installing Sendbird Chat SDK, you need to create a Sendbird application o
 
 ```yaml
 dependencies:
-  sendbird_chat_sdk: ^4.2.26
+  sendbird_chat_sdk: ^4.2.27
 ```
 
 - Run `flutter pub get` command in your project directory.

lib/src/internal/main/chat/chat.dart

@@ -62,7 +62,7 @@ part 'chat_notifications.dart';
 part 'chat_push.dart';
 part 'chat_user.dart';
 
-const sdkVersion = '4.2.26';
+const sdkVersion = '4.2.27';
 
 // Internal implementation for main class. Do not directly access this class.
 class Chat with WidgetsBindingObserver {

lib/src/internal/main/chat_manager/command_manager.dart

@@ -447,6 +447,7 @@ class CommandManager {
 
         groupChannel.updateMember(event.sender);
 
+        // Last message
         if (channel is GroupChannel && message is BaseMessage) {
           if (groupChannel.shouldUpdateLastMessage(message, message.sender)) {
             shouldCallChannelChanged = true;
@@ -459,6 +460,7 @@ class CommandManager {
           }
         }
 
+        // Unread message count
         if (groupChannel.fromCache && groupChannel.updateUnreadCount(message)) {
           shouldCallChannelChanged = true;
         }

lib/src/internal/main/chat_manager/connection_manager.dart

@@ -258,9 +258,6 @@ class ConnectionManager {
     if (isReconnecting()) {
       reconnectTimer?.cancel();
       reconnectTimer = null;
-      if (clear) {
-        chat.eventManager.notifyReconnectFailed();
-      }
     }
 
     final isClosedSuccessfully = await webSocketClient.close();
@@ -298,6 +295,9 @@ class ConnectionManager {
     if (fromEnterBackground && !chat.isBackground && !isClosedSuccessfully) {
       chat.connectionManager.reconnect(reset: true); // Check
     } else {
+      if (isReconnecting()) {
+        chat.eventManager.notifyReconnectFailed();
+      }
       changeState(DisconnectedState(chat: chat));
 
       if (clear && disconnectedUserId.isNotEmpty) {
@@ -309,11 +309,13 @@ class ConnectionManager {
   Future<bool> doReconnect({bool reset = false}) async {
     sbLog.i(StackTrace.current, 'reset: $reset');
 
+    bool doNotCallReconnectStartedEvent = false;
+    if (isReconnecting() && reset) {
+      doNotCallReconnectStartedEvent = true;
+    }
+
     if (chat.chatContext.currentUser == null ||
         chat.chatContext.sessionKey == null) {
-      if (isReconnecting()) {
-        chat.eventManager.notifyReconnectFailed();
-      }
       changeState(DisconnectedState(chat: chat));
       return false;
     }
@@ -348,8 +350,10 @@ class ConnectionManager {
       );
 
       if (chat.chatContext.reconnectTask?.retryCount == 1) {
-        await chat.eventDispatcher.onReconnecting();
-        chat.eventManager.notifyReconnectStarted();
+        if (!doNotCallReconnectStartedEvent) {
+          await chat.eventDispatcher.onReconnecting();
+          chat.eventManager.notifyReconnectStarted();
+        }
       }
 
       // ===== Reconnect =====

lib/src/internal/main/extensions/group_channel_extensions.dart

@@ -4,6 +4,10 @@ part of 'package:sendbird_chat_sdk/src/public/core/channel/group_channel/group_c
 
 extension GroupChannelExtensions on GroupChannel {
   bool shouldUpdateLastMessage(BaseMessage message, Sender? sender) {
+    if (_shouldUpdateLastMessageByThreadingPolicy(message) == false) {
+      return false;
+    }
+
     final lm = lastMessage;
     if (!message.isSilent ||
         sender?.isCurrentUser == true ||
@@ -22,6 +26,10 @@ extension GroupChannelExtensions on GroupChannel {
   }
 
   bool updateUnreadCount(RootMessage message) {
+    if (_shouldUpdateUnreadMessageCountByThreadingPolicy(message) == false) {
+      return false;
+    }
+
     final currentUser = chat.chatContext.currentUser;
 
     if (message is BaseMessage) {
@@ -165,4 +173,46 @@ extension GroupChannelExtensions on GroupChannel {
         .toList()
         .length;
   }
+
+  bool _shouldUpdateLastMessageByThreadingPolicy(RootMessage message) {
+    return _shouldUpdateByThreadingPolicy(
+      message: message,
+      threadingPolicy: chat.chatContext.appInfo?.lastMsgThreadingPolicy,
+    );
+  }
+
+  bool _shouldUpdateUnreadMessageCountByThreadingPolicy(RootMessage message) {
+    return _shouldUpdateByThreadingPolicy(
+      message: message,
+      threadingPolicy: chat.chatContext.appInfo?.unreadCntThreadingPolicy,
+    );
+  }
+
+  bool _shouldUpdateByThreadingPolicy({
+    required RootMessage message,
+    required int? threadingPolicy,
+  }) {
+    bool result = true;
+    bool isReplyMessage = message is BaseMessage &&
+        message.parentMessageId != null &&
+        message.parentMessageId! > 0;
+
+    if (isReplyMessage && threadingPolicy != null) {
+      switch (threadingPolicy) {
+        case 0: // NONE
+          break;
+        case 1: // INCLUDE_REPLY
+          break;
+        case 2: // EXCLUDE_REPLY
+          result = false;
+          break;
+        case 3: // INCLUDE_REPLY_TO_CHANNEL
+          if (message.isReplyToChannel == false) {
+            result = false;
+          }
+          break;
+      }
+    }
+    return result;
+  }
 }