Merge pull request #138 from sendbird/v4.3.1

Add 4.3.1.

Author: sf-tyler-jeong

CHANGELOG.md

@@ -1,3 +1,9 @@
+## v4.3.1 (Apr 4, 2025)
+
+### Improvements
+- Fixed duplicate userId bug related to reaction
+- Improved websocket statistics
+
 ## v4.3.0 (Mar 11, 2025)
 
 ### Features

README.md

@@ -50,7 +50,7 @@ Before installing Sendbird Chat SDK, you need to create a Sendbird application o
 
 ```yaml
 dependencies:
-  sendbird_chat_sdk: ^4.3.0
+  sendbird_chat_sdk: ^4.3.1
 ```
 
 - Run `flutter pub get` command in your project directory.

lib/src/internal/main/chat/chat.dart

@@ -64,7 +64,7 @@ part 'chat_notifications.dart';
 part 'chat_push.dart';
 part 'chat_user.dart';
 
-const sdkVersion = '4.3.0';
+const sdkVersion = '4.3.1';
 
 // Internal implementation for main class. Do not directly access this class.
 class Chat with WidgetsBindingObserver {
@@ -257,6 +257,12 @@ class Chat with WidgetsBindingObserver {
         } else if (results.contains(ConnectivityResult.none)) {
           channelCache.markAsDirtyAll(); // Check
 
+          statManager.appendWsDisconnectStat(
+            success: true,
+            errorCode: SendbirdError.networkError,
+            errorDescription: "cause=network_closed",
+          );
+
           sbLog.d(StackTrace.current, 'disconnect()');
           await connectionManager.disconnect(logout: false);
         }

lib/src/internal/main/chat/chat_connection.dart

@@ -35,6 +35,15 @@ extension ChatConnection on Chat {
 
   Future<bool> reconnect({bool reset = false}) async {
     sbLog.i(StackTrace.current, 'userId: ${chatContext.currentUserId}');
+
+    if (reset) {
+      statManager.appendWsDisconnectStat(
+        success: true,
+        errorCode: 0,
+        errorDescription: "cause=explicit_reconnect",
+      );
+    }
+
     return await connectionManager.reconnect(reset: reset);
   }
 

lib/src/internal/main/chat_manager/command_manager.dart

@@ -49,6 +49,8 @@ class CommandManager {
   final Map<String, int> _readMap = {};
   final Map<String, Completer<int?>> messageOffsetTsCompleterMap = {};
 
+  int? logiTs;
+
   final Chat _chat;
 
   CommandManager({required Chat chat}) : _chat = chat;
@@ -275,6 +277,8 @@ class CommandManager {
       return;
     }
 
+    logiTs = DateTime.now().millisecondsSinceEpoch;
+
     await processLoginPayload(fromWebSocket: true, loginPayload: cmd.payload);
   }
 
@@ -390,6 +394,12 @@ class CommandManager {
       await _chat.connectionManager.disconnect(logout: true);
       _chat.eventManager.notifySessionClosed();
     } else {
+      _chat.statManager.appendWsDisconnectStat(
+        success: true,
+        errorCode: SendbirdError.sessionKeyExpired,
+        errorDescription: "cause=session_expired",
+      );
+
       await _chat.sessionManager.updateSessionKey();
     }
   }

lib/src/internal/main/chat_manager/connection_manager.dart

@@ -18,6 +18,7 @@ import 'package:sendbird_chat_sdk/src/internal/network/websocket/command/command
 import 'package:sendbird_chat_sdk/src/internal/network/websocket/websocket_client.dart';
 import 'package:sendbird_chat_sdk/src/public/core/user/user.dart';
 import 'package:sendbird_chat_sdk/src/public/main/define/exceptions.dart';
+import 'package:sendbird_chat_sdk/src/public/main/define/sendbird_error.dart';
 import 'package:universal_io/io.dart';
 
 class ConnectionManager {
@@ -29,6 +30,7 @@ class ConnectionManager {
 
   ConnectionManager({required this.chat}) {
     webSocketClient = WebSocketClient(
+      chat: chat,
       chatContext: chat.chatContext,
       onWebSocketConnected: _onWebSocketConnected,
       onWebSocketClosed: _onWebSocketClosed,
@@ -175,6 +177,7 @@ class ConnectionManager {
               success: false,
               errorCode: e.code,
               errorDescription: e.message,
+              accumTrial: 1,
             );
 
             //+ [DBManager]
@@ -205,6 +208,7 @@ class ConnectionManager {
               success: false,
               errorCode: exception.code,
               errorDescription: exception.message,
+              accumTrial: 1,
             );
 
             if (chat.chatContext.loginCompleter != null &&
@@ -226,6 +230,7 @@ class ConnectionManager {
         success: false,
         errorCode: e.code,
         errorDescription: e.name,
+        accumTrial: 1,
       );
 
       await doDisconnect(clear: true);
@@ -236,6 +241,9 @@ class ConnectionManager {
     chat.statManager.endWsConnectStat(
       hostUrl: url,
       success: true,
+      connectedTs: webSocketClient.connectedTs,
+      logiTs: chat.commandManager.logiTs,
+      accumTrial: 1,
     );
     return user;
   }
@@ -405,6 +413,15 @@ class ConnectionManager {
 
   void _onWebSocketClosed() {
     chat.commandManager.clearCompleterMap();
+
+    final closeCode = webSocketClient.getCloseCode();
+    if (closeCode != null) {
+      chat.statManager.appendWsDisconnectStat(
+        success: true,
+        errorCode: SendbirdError.webSocketConnectionClosed,
+        errorDescription: "cause=$closeCode",
+      );
+    }
   }
 
   Future<void> _onWebSocketData(dynamic data) async {

lib/src/internal/main/connection_state/connected_state.dart

@@ -5,6 +5,7 @@ import 'package:sendbird_chat_sdk/src/internal/main/chat_context/chat_context.da
 import 'package:sendbird_chat_sdk/src/internal/main/connection_state/base_connection_state.dart';
 import 'package:sendbird_chat_sdk/src/internal/main/logger/sendbird_logger.dart';
 import 'package:sendbird_chat_sdk/src/public/core/user/user.dart';
+import 'package:sendbird_chat_sdk/src/public/main/define/sendbird_error.dart';
 
 class ConnectedState extends BaseConnectionState {
   ConnectedState({
@@ -51,6 +52,13 @@ class ConnectedState extends BaseConnectionState {
   @override
   Future<void> enterBackground() async {
     sbLog.i(StackTrace.current);
+
+    chat.statManager.appendWsDisconnectStat(
+      success: true,
+      errorCode: SendbirdError.webSocketConnectionClosed,
+      errorDescription: "cause=background",
+    );
+
     await chat.connectionManager
         .doDisconnect(clear: false, fromEnterBackground: true);
   }

lib/src/internal/main/stats/daily_record_stat_prefs.dart

@@ -95,6 +95,8 @@ class DailyRecordStatPrefs {
           return null;
         case StatType.wsConnect:
           return null;
+        case StatType.wsDisconnect:
+          return null;
         case StatType.featureLocalCache:
           return LocalCacheStat.fromJson(ts: ts, data: data);
         case StatType.featureLocalCacheEvent:

lib/src/internal/main/stats/default_stat_prefs.dart

@@ -8,6 +8,7 @@ import 'package:sendbird_chat_sdk/src/internal/main/stats/model/default/api_resu
 import 'package:sendbird_chat_sdk/src/internal/main/stats/model/default/default_stat.dart';
 import 'package:sendbird_chat_sdk/src/internal/main/stats/model/default/local_cache_event_stat.dart';
 import 'package:sendbird_chat_sdk/src/internal/main/stats/model/default/notification_stat.dart';
+import 'package:sendbird_chat_sdk/src/internal/main/stats/model/default/ws_disconnect_stat.dart';
 import 'package:sendbird_chat_sdk/src/internal/main/stats/stat_type.dart';
 import 'package:sendbird_chat_sdk/src/internal/main/stats/stat_utils.dart';
 import 'package:sendbird_chat_sdk/src/internal/main/stats/model/default/ws_connect_stat.dart';
@@ -85,6 +86,8 @@ class DefaultStatPrefs {
           return ApiResultStat.fromJson(ts: ts, data: data);
         case StatType.wsConnect:
           return WsConnectStat.fromJson(ts: ts, data: data);
+        case StatType.wsDisconnect:
+          return WsDisconnectStat.fromJson(ts: ts, data: data);
         case StatType.featureLocalCache:
           return null;
         case StatType.featureLocalCacheEvent:

lib/src/internal/main/stats/model/default/ws_connect_stat.dart

@@ -7,7 +7,10 @@ import 'package:sendbird_chat_sdk/src/internal/main/stats/stat_type.dart';
 class WsConnectStat extends DefaultStat {
   final String hostUrl; // ws host url
   final bool success; // success or not
-  final int latency; // roundtrip latency
+  final int latency; // until connected or failed
+  final int accumTrial;
+  final String connectionId;
+  final int? logiLatency; // until received LOGI
   final int? errorCode; // error code if exist
   final String? errorDescription; // detailed error message
 
@@ -16,6 +19,9 @@ class WsConnectStat extends DefaultStat {
     required this.hostUrl,
     required this.success,
     required this.latency,
+    required this.accumTrial,
+    required this.connectionId,
+    this.logiLatency,
     this.errorCode,
     this.errorDescription,
   }) : super(StatType.wsConnect, ts);
@@ -26,6 +32,9 @@ class WsConnectStat extends DefaultStat {
       'host_url': hostUrl,
       'success': success,
       'latency': latency,
+      'accum_trial': accumTrial,
+      'connection_id': connectionId,
+      'logi_latency': logiLatency,
       'error_code': errorCode,
       'error_description': errorDescription,
     };
@@ -41,6 +50,9 @@ class WsConnectStat extends DefaultStat {
   //     'host_url': String,
   //     'success': bool,
   //     'latency': int,
+  //     'accum_trial': int,
+  //     'connection_id': String,
+  //     'logi_latency': int?,
   //     'error_code': int?,
   //     'error_description': String?,
   //   },
@@ -53,10 +65,17 @@ class WsConnectStat extends DefaultStat {
       final String? hostUrl = data['host_url'] as String?;
       final bool? success = data['success'] as bool?;
       final int? latency = data['latency'] as int?;
+      final int? accumTrial = data['accum_trial'] as int?;
+      final String? connectionId = data['connection_id'] as String?;
+      final int? logiLatency = data['logi_latency'] as int?;
       final int? errorCode = data['error_code'] as int?;
       final String? errorDescription = data['error_description'] as String?;
 
-      if (hostUrl == null || success == null || latency == null) {
+      if (hostUrl == null ||
+          success == null ||
+          latency == null ||
+          accumTrial == null ||
+          connectionId == null) {
         return null;
       }
 
@@ -65,6 +84,9 @@ class WsConnectStat extends DefaultStat {
         hostUrl: hostUrl,
         success: success,
         latency: latency,
+        accumTrial: accumTrial,
+        connectionId: connectionId,
+        logiLatency: logiLatency,
         errorCode: errorCode,
         errorDescription: errorDescription,
       );

lib/src/internal/main/stats/model/default/ws_disconnect_stat.dart

@@ -0,0 +1,64 @@
+// Copyright (c) 2025 Sendbird, Inc. All rights reserved.
+
+import 'package:sendbird_chat_sdk/src/internal/main/logger/sendbird_logger.dart';
+import 'package:sendbird_chat_sdk/src/internal/main/stats/model/default/default_stat.dart';
+import 'package:sendbird_chat_sdk/src/internal/main/stats/stat_type.dart';
+
+class WsDisconnectStat extends DefaultStat {
+  final bool success; // success or not
+  final int errorCode; // error code
+  final String errorDescription; // detailed error message
+
+  WsDisconnectStat({
+    required int ts,
+    required this.success,
+    required this.errorCode,
+    required this.errorDescription,
+  }) : super(StatType.wsDisconnect, ts);
+
+  @override
+  Map<String, dynamic> toJson() {
+    final json = <String, dynamic>{
+      'success': success,
+      'error_code': errorCode,
+      'error_description': errorDescription,
+    };
+    final result = super.toJson();
+    result['data'] = json;
+    return result;
+  }
+
+  // {
+  //   'stat_type' : 'ws:disconnect',
+  //   'ts': int, // timestamp for log creation,
+  //   'data' : {
+  //     'success': bool,
+  //     'error_code': int,
+  //     'error_description': String,
+  //   },
+  // }
+  static WsDisconnectStat? fromJson({
+    required int ts,
+    required Map<String, dynamic> data,
+  }) {
+    try {
+      final bool? success = data['success'] as bool?;
+      final int? errorCode = data['error_code'] as int?;
+      final String? errorDescription = data['error_description'] as String?;
+
+      if (success == null || errorCode == null || errorDescription == null) {
+        return null;
+      }
+
+      return WsDisconnectStat(
+        ts: ts,
+        success: success,
+        errorCode: errorCode,
+        errorDescription: errorDescription,
+      );
+    } catch (e) {
+      sbLog.d(StackTrace.current, 'e: ${e.toString()}');
+    }
+    return null;
+  }
+}

lib/src/internal/main/stats/sendbird_statistics.dart

@@ -8,6 +8,7 @@ import 'package:sendbird_chat_sdk/src/public/main/chat/sendbird_chat.dart';
 class SendbirdStatistics {
   static const String apiResultType = 'api:result';
   static const String wsConnectType = 'ws:connect';
+  static const String wsDisconnectType = 'ws:disconnect';
   static const String featureLocalCacheType = 'feature:local_cache';
   static const String featureLocalCacheEventType = 'feature:local_cache_event';
   static const String notiStatsType = 'noti:stats';