switch S3 upload path to branch/tag name

Author: tve

.github/workflows/build.yml

@@ -3,8 +3,11 @@ name: Build package
 on: [push]
 
 env:
+  # Upload to AWS uses OIDC for federated auth:
+  # https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-amazon-web-services
   S3_PATH: motus-builds/${{github.repository}}
   S3_REGION: us-east-2
+  AWS_ROLE: arn:aws:iam::635201719205:role/Github-actions-motus
 
 permissions:
   id-token: write
@@ -18,26 +21,34 @@ jobs:
         uses: actions/checkout@v2
         with:
           path: .
-      - run: echo "GIT_DESC=$(git describe --tags --dirty --always)" >>$GITHUB_ENV
+
+      # use branch or tag name in S3 upload path
+      - run: echo GIT_REF=${{github.ref}} | sed -e 's;refs/[^/]*/;;' >>$GITHUB_ENV
+
       - name: Generate .deb packages
         run: ./gen-package.sh
         shell: bash
       - run: ls -ls packages
+
+      # Upload github artifacts for debugging purposes
       - uses: actions/upload-artifact@v2
         with:
           name: deb-packages
           path: packages
+
       - name: Configure AWS Credentials
         # See https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-amazon-web-services
         uses: aws-actions/configure-aws-credentials@master
         with:
-          role-to-assume: arn:aws:iam::635201719205:role/Github-actions-motus
+          role-to-assume: ${{env.AWS_ROLE}}
           role-session-name: GithubActionsMotus
           aws-region: ${{ env.S3_REGION }}
+
       - name: Upload .debs to AWS S3 repo
         run: |
-          aws s3 sync --acl public-read packages s3://${{env.S3_PATH}}/$GIT_DESC/
-      - name: Link to packages on S3
+          aws s3 sync --acl public-read packages s3://${{env.S3_PATH}}/$GIT_REF/
+
+      - name: Create annotation with link to packages on S3
         run: |
-          echo "https://${{env.S3_PATH}}/$GIT_DESC/"
-          echo "::notice title=Packages::https://${{env.S3_PATH}}/$GIT_DESC/"
+          echo "https://${{env.S3_PATH}}/$GIT_REF/"
+          echo "::notice title=Packages::https://${{env.S3_PATH}}/$GIT_REF/"