score up as Dart Package, part2 (#118)

* run pana

* ignore unused_xxx

* update analysis config for pana

* fix ci

* format

* bump version

* fix workflow

* fix

* mild fix

* fix

* mild fix

* fix

* fix version

* fix version

Author: sensuikan1973

.github/workflows/dart_ci.yaml

@@ -28,8 +28,7 @@ jobs:
     steps:
     - uses: actions/checkout@v2
     - uses: dart-lang/setup-dart@v1
-    - name: dart format
-      run: dart format ./ -l 120 --set-exit-if-changed
+    - run: dart format . --set-exit-if-changed
 
   analyze:
     runs-on: ubuntu-latest
@@ -39,8 +38,7 @@ jobs:
     - uses: dart-lang/setup-dart@v1
     - name: install dependencies
       run: dart pub get
-    - name: analyzer
-      run: dart analyze --fatal-infos --fatal-warnings .
+    - run: dart analyze --fatal-infos --fatal-warnings .
 
   test:
     needs: [format, analyze]
@@ -88,6 +86,22 @@ jobs:
       with:
         file: lcov.info
 
+    - name: run pana to chceck package score before publish
+      if: runner.os == 'Linux'
+      id: run_pana_step
+      run: |
+        pub_point_by_pana=$(dart run pana | tail -1)
+        echo "::set-output name=pub_point_by_pana::$pub_point_by_pana"
+
+    - uses: Sibz/github-status-action@v1
+      if: runner.os == 'Linux'
+      with:
+        authToken: ${{ secrets.GITHUB_TOKEN }}
+        context: Pub Poits by Pana
+        description: ${{ steps.run_pana_step.outputs.pub_point_by_pana }}
+        state: success
+        sha: ${{ github.event.pull_request.head.sha || github.sha }}
+
     - name: run example
       run: |-
         cd example && dart pub get && cd ..

CHANGELOG.md

@@ -1,3 +1,7 @@
+# 2.9.1
+
+- follow Dart Package ecosystem changed. (See: https://github.com/sensuikan1973/libedax4dart/pull/118)
+
 # 2.9.0
 
 - follow Dart Package ecosystem changed. (See: https://github.com/sensuikan1973/libedax4dart/pull/117)

README.md

@@ -50,7 +50,9 @@ dart example/example.dart
 #### format
 
 ```sh
-dart format --fix -l 120 .
+# fix with line length 80 for pana, although I don't like.
+# See: https://github.com/dart-lang/dart_style/issues/918
+dart format --fix .
 ```
 
 #### test
@@ -63,6 +65,14 @@ dart run test .
 
 ```sh
 dart analyze .
+
+dart fix --apply # auto fix
+```
+
+#### [pana](https://pub.dev/packages/pana)
+
+```sh
+dart run pana
 ```
 
 #### document
@@ -81,8 +91,8 @@ libedax_build_command="make libbuild ARCH=x64-modern COMP=gcc OS=osx" dst="." ./
 #### generate bindings
 
 ```sh
-# Before this, you must run build_libedax.sh
-dart run ffigen --config ffigen.yaml --verbose severe && dart format --fix -l 120 .
+# Before this, you must run build_libedax.sh.
+dart run ffigen --config ffigen.yaml --verbose severe && dart format --fix .
 ```
 
 ### reference

example/example.dart

@@ -4,7 +4,13 @@ import 'package:libedax4dart/libedax4dart.dart';
 
 void main() {
   // initialize
-  const initParams = ['', '-book-file', './resources/test_book.dat', '-level', '16'];
+  const initParams = [
+    '',
+    '-book-file',
+    './resources/test_book.dat',
+    '-level',
+    '16'
+  ];
   final edax = LibEdax()
     ..libedaxInitialize(initParams)
     ..edaxInit();
@@ -23,8 +29,12 @@ void main() {
   /// get hints
   final hintList = edax.edaxHint(2);
   stdout
-    ..writeln('1st move: ${hintList.first.moveString}, ${hintList.first.scoreString}')
-    ..writeln('2nd move: ${hintList[1].moveString}, ${hintList[1].scoreString}');
+    ..writeln(
+      '1st move: ${hintList.first.moveString}, ${hintList.first.scoreString}',
+    )
+    ..writeln(
+      '2nd move: ${hintList[1].moveString}, ${hintList[1].scoreString}',
+    );
 
   // NOTE: If you use another command, See: https://sensuikan1973.github.io/libedax4dart/libedax4dart/LibEdax-class.html
 }

example/pubspec.lock

@@ -84,7 +84,7 @@ packages:
       path: ".."
       relative: true
     source: path
-    version: "2.9.0"
+    version: "2.9.1"
   meta:
     dependency: transitive
     description:

example/pubspec.yaml

@@ -1,5 +1,5 @@
 name: libedax4dart_example
-version: 2.9.0-example
+version: 2.9.1-example
 publish_to: none
 
 environment:

ffigen.yaml

@@ -5,7 +5,7 @@ output: 'lib/src/ffi/bindings.dart'
 sort: true
 # See: https://github.com/dart-lang/pana/issues/1013
 # See: https://dart.dev/guides/language/analysis-options#excluding-code-from-analysis
-preamble: "// ignore_for_file: type=lint"
+preamble: "// ignore_for_file: type=lint, unused_element, unused_field"
 headers:
   entry-points:
     - 'edax-reversi/src/all.c'

lib/src/board.dart

@@ -23,21 +23,25 @@ class Board {
   List<int> get squaresOfPlayer => _squares(player);
 
   /// square String list of player's bitboard.
-  List<String> get squareStringsOfPlayer => _squares(player).map(move2String).toList();
+  List<String> get squareStringsOfPlayer =>
+      _squares(player).map(move2String).toList();
 
   /// square list of opponent's bitboard.
   List<int> get squaresOfOpponent => _squares(opponent);
 
   /// square String list of opponent's bitboard.
-  List<String> get squareStringsOfOpponent => _squares(opponent).map(move2String).toList();
+  List<String> get squareStringsOfOpponent =>
+      _squares(opponent).map(move2String).toList();
 
   List<int> _squares(final int bitboard) {
     final result = <int>[];
     final target = BigInt.from(bitboard).toUnsigned(64);
     var mask = BigInt.from(0x8000000000000000).toUnsigned(64);
     var i = 0;
     while (i <= 63) {
-      if ((mask & target) == mask) result.add(63 - i); // NOTE: head of edax bitboard is "h8".
+      if ((mask & target) == mask) {
+        result.add(63 - i);
+      } // NOTE: head of edax bitboard is "h8".
       mask = mask >> 1;
       i++;
     }
@@ -58,8 +62,10 @@ class Board {
   ///
   /// e.g. `-------------------*-------**O----**O*-----O--------------------W`.
   String stringApplicableToSetboard(final int currentColor) {
-    final pStone = currentColor == TurnColor.black ? ColorChar.black : ColorChar.white;
-    final oStone = currentColor == TurnColor.black ? ColorChar.white : ColorChar.black;
+    final pStone =
+        currentColor == TurnColor.black ? ColorChar.black : ColorChar.white;
+    final oStone =
+        currentColor == TurnColor.black ? ColorChar.white : ColorChar.black;
 
     final buffer = StringBuffer();
     for (var k = 0; k < 8; k++) {
@@ -93,8 +99,10 @@ class Board {
   /// 8 - - - - - - - - 8 <br>
   ///   A B C D E F G H
   String prettyString(final int currentColor) {
-    final pStone = currentColor == TurnColor.black ? ColorChar.black : ColorChar.white;
-    final oStone = currentColor == TurnColor.black ? ColorChar.white : ColorChar.black;
+    final pStone =
+        currentColor == TurnColor.black ? ColorChar.black : ColorChar.white;
+    final oStone =
+        currentColor == TurnColor.black ? ColorChar.white : ColorChar.black;
 
     final buffer = StringBuffer()..writeln('  A B C D E F G H');
     for (var k = 0; k < 8; k++) {