Skip to content

Commit aeea711

Browse files
chore(internal): support x-stainless-mcp-client-envs header in MCP servers
1 parent 902cc44 commit aeea711

File tree

4 files changed

+43
-15
lines changed

4 files changed

+43
-15
lines changed

packages/mcp-server/src/code-tool.ts

Lines changed: 25 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -152,19 +152,23 @@ const remoteStainlessHandler = async ({
152152

153153
const codeModeEndpoint = readEnv('CODE_MODE_ENDPOINT_URL') ?? 'https://api.stainless.com/api/ai/code-tool';
154154

155+
const localClientEnvs = {
156+
SENT_DM_API_KEY: requireValue(
157+
readEnv('SENT_DM_API_KEY') ?? client.apiKey,
158+
'set SENT_DM_API_KEY environment variable or provide apiKey client option',
159+
),
160+
SENT_DM_BASE_URL: readEnv('SENT_DM_BASE_URL') ?? client.baseURL ?? undefined,
161+
};
162+
// Merge any upstream client envs from the request header, with upstream values taking precedence.
163+
const mergedClientEnvs = { ...localClientEnvs, ...reqContext.upstreamClientEnvs };
164+
155165
// Setting a Stainless API key authenticates requests to the code tool endpoint.
156166
const res = await fetch(codeModeEndpoint, {
157167
method: 'POST',
158168
headers: {
159169
...(reqContext.stainlessApiKey && { Authorization: reqContext.stainlessApiKey }),
160170
'Content-Type': 'application/json',
161-
'x-stainless-mcp-client-envs': JSON.stringify({
162-
SENT_DM_API_KEY: requireValue(
163-
readEnv('SENT_DM_API_KEY') ?? client.apiKey,
164-
'set SENT_DM_API_KEY environment variable or provide apiKey client option',
165-
),
166-
SENT_DM_BASE_URL: readEnv('SENT_DM_BASE_URL') ?? client.baseURL ?? undefined,
167-
}),
171+
'x-stainless-mcp-client-envs': JSON.stringify(mergedClientEnvs),
168172
},
169173
body: JSON.stringify({
170174
project_name: 'sent-dm',
@@ -275,6 +279,9 @@ const localDenoHandler = async ({
275279
printOutput: true,
276280
spawnOptions: {
277281
cwd: path.dirname(workerPath),
282+
// Merge any upstream client envs into the Deno subprocess environment,
283+
// with the upstream env vars taking precedence.
284+
env: { ...process.env, ...reqContext.upstreamClientEnvs },
278285
},
279286
});
280287

@@ -284,13 +291,17 @@ const localDenoHandler = async ({
284291
reject(new Error(`Worker exited with code ${exitCode}`));
285292
});
286293

287-
const opts: ClientOptions = {
288-
baseURL: client.baseURL,
289-
apiKey: client.apiKey,
290-
defaultHeaders: {
291-
'X-Stainless-MCP': 'true',
292-
},
293-
};
294+
// Strip null/undefined values so that the worker SDK client can fall back to
295+
// reading from environment variables (including any upstreamClientEnvs).
296+
const opts: ClientOptions = Object.fromEntries(
297+
Object.entries({
298+
baseURL: client.baseURL,
299+
apiKey: client.apiKey,
300+
defaultHeaders: {
301+
'X-Stainless-MCP': 'true',
302+
},
303+
}).filter(([_, v]) => v != null),
304+
) as ClientOptions;
294305

295306
const req = worker.request(
296307
'http://localhost',

packages/mcp-server/src/http.ts

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,19 @@ const newServer = async ({
2727

2828
const authOptions = parseClientAuthHeaders(req, false);
2929

30+
let upstreamClientEnvs: Record<string, string> | undefined;
31+
const clientEnvsHeader = req.headers['x-stainless-mcp-client-envs'];
32+
if (typeof clientEnvsHeader === 'string') {
33+
try {
34+
const parsed = JSON.parse(clientEnvsHeader);
35+
if (parsed && typeof parsed === 'object' && !Array.isArray(parsed)) {
36+
upstreamClientEnvs = parsed;
37+
}
38+
} catch {
39+
// Ignore malformed header
40+
}
41+
}
42+
3043
await initMcpServer({
3144
server: server,
3245
mcpOptions: mcpOptions,
@@ -35,6 +48,7 @@ const newServer = async ({
3548
...authOptions,
3649
},
3750
stainlessApiKey: stainlessApiKey,
51+
upstreamClientEnvs,
3852
});
3953

4054
return server;
@@ -72,7 +86,7 @@ const del = async (req: express.Request, res: express.Response) => {
7286
};
7387

7488
const redactHeaders = (headers: Record<string, any>) => {
75-
const hiddenHeaders = /auth|cookie|key|token/i;
89+
const hiddenHeaders = /auth|cookie|key|token|x-stainless-mcp-client-envs/i;
7690
const filtered = { ...headers };
7791
Object.keys(filtered).forEach((key) => {
7892
if (hiddenHeaders.test(key)) {

packages/mcp-server/src/server.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ export async function initMcpServer(params: {
3737
clientOptions?: ClientOptions;
3838
mcpOptions?: McpOptions;
3939
stainlessApiKey?: string | undefined;
40+
upstreamClientEnvs?: Record<string, string> | undefined;
4041
}) {
4142
const server = params.server instanceof McpServer ? params.server.server : params.server;
4243

@@ -118,6 +119,7 @@ export async function initMcpServer(params: {
118119
reqContext: {
119120
client,
120121
stainlessApiKey: params.stainlessApiKey ?? params.mcpOptions?.stainlessApiKey,
122+
upstreamClientEnvs: params.upstreamClientEnvs,
121123
},
122124
args,
123125
});

packages/mcp-server/src/types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ export type ToolCallResult = {
4545
export type McpRequestContext = {
4646
client: SentDm;
4747
stainlessApiKey?: string | undefined;
48+
upstreamClientEnvs?: Record<string, string> | undefined;
4849
};
4950

5051
export type HandlerFunction = ({

0 commit comments

Comments
 (0)