chore: register and update the node before starting the node

Author: ironman0x7b2

cmd/start.go

@@ -1,11 +1,13 @@
 package cmd
 
 import (
+	"context"
 	"fmt"
 	"os/signal"
 	"syscall"
 
 	"github.com/sentinel-official/sentinel-go-sdk/libs/log"
+	"github.com/sentinel-official/sentinel-go-sdk/utils"
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
 	"golang.org/x/sync/errgroup"
@@ -69,6 +71,14 @@ explicitly starts the node, and handles SIGINT/SIGTERM for graceful shutdown.`,
 
 			// Launch goroutine to start the node and wait.
 			eg.Go(func() error {
+				// Register the node and update its details.
+				if err := n.Register(ctx); err != nil {
+					return fmt.Errorf("registering node: %w", err)
+				}
+				if err := n.UpdateDetails(ctx); err != nil {
+					return fmt.Errorf("updating node details: %w", err)
+				}
+
 				log.Info("Starting node")
 				if err := n.Start(); err != nil {
 					return fmt.Errorf("starting node: %w", err)
@@ -83,20 +93,14 @@ explicitly starts the node, and handles SIGINT/SIGTERM for graceful shutdown.`,
 					return nil
 				})
 
-				// Register the node and update its details.
-				if err := n.Register(ctx); err != nil {
-					return fmt.Errorf("registering node: %w", err)
-				}
-				if err := n.UpdateDetails(ctx); err != nil {
-					return fmt.Errorf("updating node details: %w", err)
-				}
-
 				return nil
 			})
 
 			// Wait for all goroutines to complete.
 			if err := eg.Wait(); err != nil {
-				return err
+				if !utils.ErrorIs(err, context.Canceled) {
+					return err
+				}
 			}
 
 			log.Info("Node stopped successfully")

go.mod

@@ -7,7 +7,7 @@ require (
 	github.com/cosmos/cosmos-sdk v0.47.17
 	github.com/gin-contrib/cors v1.7.6
 	github.com/gin-gonic/gin v1.10.1
-	github.com/sentinel-official/sentinel-go-sdk v1.0.0-rc.6.0.20250826104258-944c68bd5d29
+	github.com/sentinel-official/sentinel-go-sdk v1.0.0-rc.6.0.20250826115632-ff01e4ef3e44
 	github.com/sentinel-official/sentinelhub/v12 v12.0.0-rc.11
 	github.com/spf13/cobra v1.9.1
 	github.com/spf13/pflag v1.0.7

go.sum

@@ -511,8 +511,8 @@ github.com/secure-io/siv-go v0.0.0-20180922214919-5ff40651e2c4 h1:zOjq+1/uLzn/Xo
 github.com/secure-io/siv-go v0.0.0-20180922214919-5ff40651e2c4/go.mod h1:aI+8yClBW+1uovkHw6HM01YXnYB8vohtB9C83wzx34E=
 github.com/seiflotfy/cuckoofilter v0.0.0-20220411075957-e3b120b3f5fb h1:XfLJSPIOUX+osiMraVgIrMR27uMXnRJWGm1+GL8/63U=
 github.com/seiflotfy/cuckoofilter v0.0.0-20220411075957-e3b120b3f5fb/go.mod h1:bR6DqgcAl1zTcOX8/pE2Qkj9XO00eCNqmKb7lXP8EAg=
-github.com/sentinel-official/sentinel-go-sdk v1.0.0-rc.6.0.20250826104258-944c68bd5d29 h1:NJZLzxhNl1IJ9YoU2y92WFDNVYP6MmaYRNp0NCj+MuI=
-github.com/sentinel-official/sentinel-go-sdk v1.0.0-rc.6.0.20250826104258-944c68bd5d29/go.mod h1:jatyUZIc/7I7xmLI6fmbhzMjJ+si04XR2f0CksWtiXw=
+github.com/sentinel-official/sentinel-go-sdk v1.0.0-rc.6.0.20250826115632-ff01e4ef3e44 h1:zXo3qyKpKX4klGnhiDcfSGt0QU+cQQB2txgqM8EF2zs=
+github.com/sentinel-official/sentinel-go-sdk v1.0.0-rc.6.0.20250826115632-ff01e4ef3e44/go.mod h1:jatyUZIc/7I7xmLI6fmbhzMjJ+si04XR2f0CksWtiXw=
 github.com/sentinel-official/sentinelhub/v12 v12.0.0-rc.11 h1:B3ylnKZSLP9aDYnS2f98Gx/QTohPuD36tjl75kYJSMs=
 github.com/sentinel-official/sentinelhub/v12 v12.0.0-rc.11/go.mod h1:LXcOAEffAn4Pw58xhoYN9j8ZVuM02OCgPNTI6lkGG2E=
 github.com/shirou/gopsutil/v4 v4.25.7 h1:bNb2JuqKuAu3tRlPv5piSmBZyMfecwQ+t/ILq+1JqVM=

node/node.go

@@ -115,10 +115,10 @@ func (n *Node) UpdateDetails(ctx context.Context) error {
 
 // Start initializes the Node's services, scheduler, and API server.
 func (n *Node) Start() error {
-	eg := &errgroup.Group{}
+	sg := &errgroup.Group{}
 
 	// Launch the service stack as a background goroutine.
-	eg.Go(func() error {
+	sg.Go(func() error {
 		log.Info("Running service pre-up task")
 		if err := n.Service().PreUp(); err != nil {
 			return fmt.Errorf("running service pre-up task: %w", err)
@@ -146,7 +146,7 @@ func (n *Node) Start() error {
 	})
 
 	// Launch the cron-based job scheduler in the background.
-	eg.Go(func() error {
+	sg.Go(func() error {
 		log.Info("Starting scheduler")
 		if err := n.Scheduler().Start(); err != nil {
 			return fmt.Errorf("starting scheduler: %w", err)
@@ -164,7 +164,7 @@ func (n *Node) Start() error {
 	})
 
 	// Launch the API server using the configured TLS certificates and router.
-	eg.Go(func() error {
+	sg.Go(func() error {
 		log.Info("Starting API server", "addr", n.APIListenAddr())
 		if err := n.Server().Start(); err != nil {
 			return fmt.Errorf("starting API server: %w", err)
@@ -182,7 +182,7 @@ func (n *Node) Start() error {
 	})
 
 	// Wait until all routines started
-	if err := eg.Wait(); err != nil {
+	if err := sg.Wait(); err != nil {
 		return err
 	}
 
@@ -200,9 +200,9 @@ func (n *Node) Wait() error {
 
 // Stop gracefully stops the Node's operations.
 func (n *Node) Stop() error {
-	eg := &errgroup.Group{}
+	sg := &errgroup.Group{}
 
-	eg.Go(func() error {
+	sg.Go(func() error {
 		log.Info("Running service pre-down task")
 		if err := n.Service().PreDown(); err != nil {
 			return fmt.Errorf("running service pre-down task: %w", err)
@@ -221,7 +221,7 @@ func (n *Node) Stop() error {
 		return nil
 	})
 
-	eg.Go(func() error {
+	sg.Go(func() error {
 		log.Info("Stopping scheduler")
 		if err := n.Scheduler().Stop(); err != nil {
 			return fmt.Errorf("stopping scheduler: %w", err)
@@ -230,7 +230,7 @@ func (n *Node) Stop() error {
 		return nil
 	})
 
-	eg.Go(func() error {
+	sg.Go(func() error {
 		log.Info("Stopping API server")
 		if err := n.Server().Stop(); err != nil {
 			return fmt.Errorf("stopping API server: %w", err)
@@ -239,7 +239,7 @@ func (n *Node) Stop() error {
 		return nil
 	})
 
-	if err := eg.Wait(); err != nil {
+	if err := sg.Wait(); err != nil {
 		return err
 	}