fix: sanitize the prices with node module params

Author: ironman0x7b2

core/context.go

@@ -1,6 +1,7 @@
 package core
 
 import (
+	"context"
 	"errors"
 	"io"
 	"path/filepath"
@@ -250,6 +251,26 @@ func (c *Context) TLSKeyFile() string {
 	return filepath.Join(c.HomeDir(), "tls.key")
 }
 
+// SanitizedGigabytePrices returns gigabyte prices filtered to include only valid denominations.
+func (c *Context) SanitizedGigabytePrices(ctx context.Context) v1.Prices {
+	params, err := c.Client().NodeParams(ctx)
+	if err != nil {
+		panic(err)
+	}
+
+	return c.sanitizePrices(c.GigabytePrices(), params.GetMinGigabytePrices())
+}
+
+// SanitizedHourlyPrices returns hourly prices filtered to include only valid denominations.
+func (c *Context) SanitizedHourlyPrices(ctx context.Context) v1.Prices {
+	params, err := c.Client().NodeParams(ctx)
+	if err != nil {
+		panic(err)
+	}
+
+	return c.sanitizePrices(c.HourlyPrices(), params.GetMinHourlyPrices())
+}
+
 // SetLocation sets the geolocation data in the context.
 func (c *Context) SetLocation(location *geoip.Location) {
 	c.fm.Lock()
@@ -409,3 +430,15 @@ func (c *Context) checkSealed() {
 		panic(errors.New("context is sealed"))
 	}
 }
+
+// sanitizePrices filters and validates a set of prices against the minimum required prices.
+func (c *Context) sanitizePrices(prices v1.Prices, minPrices v1.Prices) (newPrices v1.Prices) {
+	m := minPrices.Map()
+	for _, price := range prices {
+		if _, ok := m[price.Denom]; ok {
+			newPrices = newPrices.Add(price)
+		}
+	}
+
+	return
+}

node/node.go

@@ -80,17 +80,20 @@ func (n *Node) Register(ctx context.Context) error {
 		return nil
 	}
 
+	gigabytePrices := n.Context().SanitizedGigabytePrices(ctx)
+	hourlyPrices := n.Context().SanitizedHourlyPrices(ctx)
+
 	log.Info("Registering node",
-		"gigabyte_price", n.Context().GigabytePrices(),
-		"hourly_price", n.Context().HourlyPrices(),
+		"gigabyte_prices", gigabytePrices,
+		"hourly_price", hourlyPrices,
 		"remote_addrs", n.Context().APIAddrs(),
 	)
 
 	// Prepare a message to register the node.
 	msg := v3.NewMsgRegisterNodeRequest(
 		n.Context().AccAddr(),
-		n.Context().GigabytePrices(),
-		n.Context().HourlyPrices(),
+		gigabytePrices,
+		hourlyPrices,
 		n.Context().APIAddrs(),
 	)
 
@@ -106,17 +109,20 @@ func (n *Node) Register(ctx context.Context) error {
 
 // UpdateDetails updates the node's pricing and address details on the network.
 func (n *Node) UpdateDetails(ctx context.Context) error {
+	gigabytePrices := n.Context().SanitizedGigabytePrices(ctx)
+	hourlyPrices := n.Context().SanitizedHourlyPrices(ctx)
+
 	log.Info("Updating node details",
-		"gigabyte_prices", n.Context().GigabytePrices(),
-		"hourly_prices", n.Context().HourlyPrices(),
+		"gigabyte_prices", gigabytePrices,
+		"hourly_prices", hourlyPrices,
 		"remote_addrs", n.Context().APIAddrs(),
 	)
 
 	// Prepare a message to update the node's details.
 	msg := v3.NewMsgUpdateNodeDetailsRequest(
 		n.Context().NodeAddr(),
-		n.Context().GigabytePrices(),
-		n.Context().HourlyPrices(),
+		gigabytePrices,
+		hourlyPrices,
 		n.Context().APIAddrs(),
 	)
 

workers/node.go

@@ -54,7 +54,7 @@ func NewNodePricesUpdateWorker(c *core.Context, interval time.Duration) cron.Wor
 
 		var gigabytePrices v1.Prices
 
-		for _, price := range c.GigabytePrices() {
+		for _, price := range c.SanitizedGigabytePrices(ctx) {
 			price, err := price.UpdateQuoteValue(ctx, client.GetQuotePrice)
 			if err != nil {
 				return fmt.Errorf("updating quote price for denom %q: %w", price.Denom, err)
@@ -65,7 +65,7 @@ func NewNodePricesUpdateWorker(c *core.Context, interval time.Duration) cron.Wor
 
 		var hourlyPrices v1.Prices
 
-		for _, price := range c.HourlyPrices() {
+		for _, price := range c.SanitizedHourlyPrices(ctx) {
 			price, err := price.UpdateQuoteValue(ctx, client.GetQuotePrice)
 			if err != nil {
 				return fmt.Errorf("updating quote price for denom %q: %w", price.Denom, err)