fix: remove panic in sanitized prices method in context

Author: ironman0x7b2

core/context.go

@@ -3,6 +3,7 @@ package core
 import (
 	"context"
 	"errors"
+	"fmt"
 	"io"
 	"path/filepath"
 	"sync"
@@ -252,23 +253,33 @@ func (c *Context) TLSKeyFile() string {
 }
 
 // SanitizedGigabytePrices returns gigabyte prices filtered to include only valid denominations.
-func (c *Context) SanitizedGigabytePrices(ctx context.Context) v1.Prices {
+func (c *Context) SanitizedGigabytePrices(ctx context.Context) (v1.Prices, error) {
 	params, err := c.Client().NodeParams(ctx)
 	if err != nil {
-		panic(err)
+		return nil, fmt.Errorf("getting node params: %w", err)
 	}
 
-	return c.sanitizePrices(c.GigabytePrices(), params.GetMinGigabytePrices())
+	prices := c.sanitizePrices(
+		c.GigabytePrices(),
+		params.GetMinGigabytePrices(),
+	)
+
+	return prices, nil
 }
 
 // SanitizedHourlyPrices returns hourly prices filtered to include only valid denominations.
-func (c *Context) SanitizedHourlyPrices(ctx context.Context) v1.Prices {
+func (c *Context) SanitizedHourlyPrices(ctx context.Context) (v1.Prices, error) {
 	params, err := c.Client().NodeParams(ctx)
 	if err != nil {
-		panic(err)
+		return nil, fmt.Errorf("getting node params: %w", err)
 	}
 
-	return c.sanitizePrices(c.HourlyPrices(), params.GetMinHourlyPrices())
+	prices := c.sanitizePrices(
+		c.HourlyPrices(),
+		params.GetMinHourlyPrices(),
+	)
+
+	return prices, nil
 }
 
 // SetLocation sets the geolocation data in the context.

node/node.go

@@ -80,8 +80,15 @@ func (n *Node) Register(ctx context.Context) error {
 		return nil
 	}
 
-	gigabytePrices := n.Context().SanitizedGigabytePrices(ctx)
-	hourlyPrices := n.Context().SanitizedHourlyPrices(ctx)
+	gigabytePrices, err := n.Context().SanitizedGigabytePrices(ctx)
+	if err != nil {
+		return fmt.Errorf("sanitizing gigabyte prices: %w", err)
+	}
+
+	hourlyPrices, err := n.Context().SanitizedHourlyPrices(ctx)
+	if err != nil {
+		return fmt.Errorf("sanitizing hourly prices: %w", err)
+	}
 
 	log.Info("Registering node",
 		"gigabyte_prices", gigabytePrices,
@@ -109,8 +116,15 @@ func (n *Node) Register(ctx context.Context) error {
 
 // UpdateDetails updates the node's pricing and address details on the network.
 func (n *Node) UpdateDetails(ctx context.Context) error {
-	gigabytePrices := n.Context().SanitizedGigabytePrices(ctx)
-	hourlyPrices := n.Context().SanitizedHourlyPrices(ctx)
+	gigabytePrices, err := n.Context().SanitizedGigabytePrices(ctx)
+	if err != nil {
+		return fmt.Errorf("sanitizing gigabyte prices: %w", err)
+	}
+
+	hourlyPrices, err := n.Context().SanitizedHourlyPrices(ctx)
+	if err != nil {
+		return fmt.Errorf("sanitizing hourly prices: %w", err)
+	}
 
 	log.Info("Updating node details",
 		"gigabyte_prices", gigabytePrices,

workers/node.go

@@ -46,15 +46,24 @@ func NewNodeStatusUpdateWorker(c *core.Context, interval time.Duration) cron.Wor
 // NewNodePricesUpdateWorker creates a worker that periodically updates the node's prices on the blockchain.
 // The worker computes the current quote prices using the OracleClient and broadcasts a MsgUpdateNodeDetailsRequest.
 func NewNodePricesUpdateWorker(c *core.Context, interval time.Duration) cron.Worker {
-	handlerFunc := func(ctx context.Context) error {
+	handlerFunc := func(ctx context.Context) (err error) {
 		client := c.OracleClient()
 		if client == nil {
 			return nil
 		}
 
-		var gigabytePrices v1.Prices
+		var (
+			prices         v1.Prices
+			gigabytePrices v1.Prices
+			hourlyPrices   v1.Prices
+		)
 
-		for _, price := range c.SanitizedGigabytePrices(ctx) {
+		prices, err = c.SanitizedGigabytePrices(ctx)
+		if err != nil {
+			return fmt.Errorf("sanitizing gigabyte prices: %w", err)
+		}
+
+		for _, price := range prices {
 			price, err := price.UpdateQuoteValue(ctx, client.GetQuotePrice)
 			if err != nil {
 				return fmt.Errorf("updating quote price for denom %q: %w", price.Denom, err)
@@ -63,9 +72,12 @@ func NewNodePricesUpdateWorker(c *core.Context, interval time.Duration) cron.Wor
 			gigabytePrices = gigabytePrices.Add(price)
 		}
 
-		var hourlyPrices v1.Prices
+		prices, err = c.SanitizedHourlyPrices(ctx)
+		if err != nil {
+			return fmt.Errorf("sanitizing hourly prices: %w", err)
+		}
 
-		for _, price := range c.SanitizedHourlyPrices(ctx) {
+		for _, price := range prices {
 			price, err := price.UpdateQuoteValue(ctx, client.GetQuotePrice)
 			if err != nil {
 				return fmt.Errorf("updating quote price for denom %q: %w", price.Denom, err)